ssh.get() parameters are reversed about node-ssh HOT 6 CLOSED

I did that because it makes the perfect sense to me, you write the path to the file you wanna fetch and then you write where you wanna store it. Also changing it at this point would be breaking compatibility, I won't mind doing this in the next major bump though

from node-ssh.

But you have to change it in the method. The param for the remote path is
used on the local machine and vice versa. The order of the params is
correct. It displays the direction of data transfer.

Steel Brain [email protected] schrieb am Mo., 30. Mai 2016, 20:27:

I did that because it makes the perfect sense to me, you write the path to
the file you wanna fetch and then you write where you wanna store it. Also
changing it at this point would be breaking compatibility, I won't mind
doing this in the next major bump though

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#20 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANNKzO-rkEhkOqhLaW1f84O2MdraXbtOks5qGywTgaJpZM4IpzLo
.

from node-ssh.

I've added this to v3.0.0 milestone btw

from node-ssh.

Fixed in v3.0.0

from node-ssh.

Nice :) Thank you.

from node-ssh.

Just a reminder that there are a lot of API breaking changes in the new release, make sure to read CHANGELOG.md

from node-ssh.