Git Product home page Git Product logo

Comments (15)

swordfischer avatar swordfischer commented on July 25, 2024

I will merge this later unless someone has any objections?

from steamlug.org.

Cheeseness avatar Cheeseness commented on July 25, 2024

Did you end up making an expanding version?

from steamlug.org.

swordfischer avatar swordfischer commented on July 25, 2024

No.

from steamlug.org.

Cheeseness avatar Cheeseness commented on July 25, 2024

We were also talking about popping these in
http://mumble.sourceforge.net/Mumble_URL

from steamlug.org.

swordfischer avatar swordfischer commented on July 25, 2024

Don't think that the expanding version is worth the effort.

Also, pretty sure that the url-ything is hard to achieve as it only knows the current path to the channel, and not the full path.

from steamlug.org.

Cheeseness avatar Cheeseness commented on July 25, 2024

I feel that the expanded version is a bit long, especially since we've got so many channels now.

I'm not sure I follow you on path stuff. If that's just the page not keeping track of the path as it iterates through the channels, that'll pretty trivial to keep track of.

from steamlug.org.

swordfischer avatar swordfischer commented on July 25, 2024

Ah cool, I take it you make it then?

Long? We got more content on the other pages, like servers?

from steamlug.org.

Cheeseness avatar Cheeseness commented on July 25, 2024

I'm happy to give you a hand working it out if you need, but I'm not going to mess around with it on my own as there are other, higher priority features that need my attention, and I'm comfortable with the live page as it is now.

If you want to implement the Mumble channels as sortable tabular data like the servers page, then go nuts.

IIRC, the reason we started looking at this initially was to reduce the amount of space taken up with the current channel list and make the number/"location" of online users more readable. Not having an expanding tree seems to work against that.

from steamlug.org.

swordfischer avatar swordfischer commented on July 25, 2024

Merged the change.

from steamlug.org.

Cheeseness avatar Cheeseness commented on July 25, 2024

Can you please revert these changes and commit them to the Master (staging) branch (preferrably as a pull request that can be reviewed).

Was removing the user list as well intentional?

from steamlug.org.

swordfischer avatar swordfischer commented on July 25, 2024

No, it has been pending for over a year. Nobody bothered to accept it.

Yes, users are shown in the list now.

from steamlug.org.

Cheeseness avatar Cheeseness commented on July 25, 2024

Revert the commit and apply it to the Master (staging) branch, please. Do not let the live branch get ahead of Master.

"Nobody bothered to accept it" is also a poor response when there was unresolved discussion here along with an offer to assist with making changes.

from steamlug.org.

johndrinkwater avatar johndrinkwater commented on July 25, 2024

Why does it need reverting; can it not be additionally applied to the other branch if necessary?

from steamlug.org.

Cheeseness avatar Cheeseness commented on July 25, 2024

Or do that, but then that'll make for a messy merge next time something else gets pushed to live.

from steamlug.org.

Cheeseness avatar Cheeseness commented on July 25, 2024

Sorted with #108
Thanks

from steamlug.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.