Comments (5)
Hah, ok transport was in libp2p, my bad, moving this issue over!
from nim-chronos.
Nevermind, re-opening, it's using chronos stream.nim
tcp transport
Curiously being a tcp stream there should be no issues with fragmentation :/ I suspect some buffer is too small, will look further myself later.
from nim-chronos.
Update: up to
nim-chronos/chronos/transports/stream.nim
Line 1649 in e3ced62
data is still all there,
Edit:
Well looking further I noticed that indeed there is no fragmentation and/or no setting of SO_SNDBUF
, more over it would seem that the effective sent size is not checked either , so it might be send side indeed.. Investigating it now.
Edit2:
Hmm fragmentation seems handled here on sending:
nim-chronos/chronos/transports/stream.nim
Line 997 in e3ced62
from nim-chronos.
Bonus issue:
nim-chronos/chronos/transports/stream.nim
Line 1001 in e3ced62
Seems to complete with just the last fragment size
Side note to @dryajov : we don't check write
actual sent sizes, we return Future[void]
should prob return Future[size]
from nim-chronos.
Found the problem, again my fault related to some bad pattern (more about it vacp2p/nim-libp2p#75).
I was closing the sender side too soon, so recv would return 0
as in connection was closed.
No issue in chronos except the Bonus issue above.
from nim-chronos.
Related Issues (20)
- `getAcceptInfo` can raise an unlisted exception: ref ValueError HOT 2
- Apparent garbage collect of localCopy in datagram sendTo before data gets send in writeDatagramLoop HOT 2
- Cycle-based memory Leak under --mm:arc HOT 1
- chronos/threadsync errors when compiling documentation
- bug: TokenBucket update calculates wrong with lastUpdate timestamp HOT 1
- Reading a file asynchronously? HOT 1
- Async proc: both Option[seq[T]] and Opt[seq[T]] as return type and one of the params is generic, failed to compile with Nim-devel HOT 1
- Completing `Futures` in refc may have unexpected behavior HOT 1
- `cancelAndWait` on `or` triggers deadlock
- `SIGSEGV` in `asyncTest`-derived scenario (also, in `asyncTest`) HOT 5
- Can't compile on GCC 14 HOT 1
- ambiguous identifier: `'Result'` HOT 2
- Change header size limits HOT 2
- Its impossible to specify Future[T].Raising([]) as argument.
- What is the intended method for catching exceptions raised from asyncCheck'd Futures? HOT 4
- Why does this usage of asyncSpawn and ThreadSignalPtr leak memory? HOT 4
- Compilation errors with `-d:chronosHandleException` HOT 1
- Hash-order independent tests HOT 5
- Compilation error `invalid pragma: stackTrace: off` HOT 1
- bug: epoch calculation is incorrect HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nim-chronos.