Sending big packets & fragmentation about nim-chronos HOT 5 CLOSED

Hah, ok transport was in libp2p, my bad, moving this issue over!

from nim-chronos.

Nevermind, re-opening, it's using chronos stream.nim tcp transport

Curiously being a tcp stream there should be no issues with fragmentation :/ I suspect some buffer is too small, will look further myself later.

from nim-chronos.

Update: up to

Edit:
Well looking further I noticed that indeed there is no fragmentation and/or no setting of SO_SNDBUF, more over it would seem that the effective sent size is not checked either , so it might be send side indeed.. Investigating it now.

Edit2:
Hmm fragmentation seems handled here on sending:

from nim-chronos.

Bonus issue:

Side note to @dryajov : we don't check write actual sent sizes, we return Future[void] should prob return Future[size]

from nim-chronos.

Found the problem, again my fault related to some bad pattern (more about it vacp2p/nim-libp2p#75).
I was closing the sender side too soon, so recv would return 0 as in connection was closed.
No issue in chronos except the Bonus issue above.

from nim-chronos.