Git Product home page Git Product logo

Comments (13)

jasonvarga avatar jasonvarga commented on July 21, 2024 2

Yeah, it's fixed in develop, gonna make a release today probably.

from seo-pro.

jasonvarga avatar jasonvarga commented on July 21, 2024 2

This issue is most likely caused by a collection without a route.

For each of those collections you don't need URLs for, go into SEO Pro > Section Defaults > Your Collection then flick the sitemap enabled toggle.

from seo-pro.

jimblue avatar jimblue commented on July 21, 2024 1

Same problem here!

from seo-pro.

moritzstuker avatar moritzstuker commented on July 21, 2024 1

Same here. Any update on this?

from seo-pro.

benwellby avatar benwellby commented on July 21, 2024

@jimblue

I have also posted this topic on the forum at Statamic.

https://statamic.com/forum/3627-seo-pro-sitemap-xml-has-too-many-homepage-references

I will post back here if there is a response.

from seo-pro.

nvmpy avatar nvmpy commented on July 21, 2024

Are these homepage references just Entries within a Collection that has no route set, maybe?

seo-pro/SeoPro/TagData.php

Lines 59 to 68 in 86a7b21

return $this->data->merge([
'compiled_title' => $this->compiledTitle(),
'canonical_url' => $this->model->absoluteUrl(),
'home_url' => URL::makeAbsolute('/'),
'humans_txt' => $this->humans(),
'locale' => $this->locale(),
'alternate_locales' => $this->alternateLocales(),
'last_modified' => $this->lastModified(),
])->all();
}

canonical_url is populated via:

    /**
     * Get the full, absolute URL
     *
     * @return string
     */
    public function absoluteUrl()
    {
        return URL::makeAbsolute(
            URL::prependSiteUrl($this->uri(), $this->locale()),
            $this->locale()
        );
    }

where $this->uri() is null if there's no route set.

from seo-pro.

benwellby avatar benwellby commented on July 21, 2024

Thank you @jasonvarga

I can confirm downloading the latest version of SEO Pro solves the issue.

Perfect!

from seo-pro.

benwellby avatar benwellby commented on July 21, 2024

There is still a slight issue…

I can't exclude a collection from both a generated sitemap 'and' the SEO Pro reports.

When setting a default for a section, let's call it "My Collection":

SEO Pro > Section Defaults > My Collection

I can't disable a section 'and' exclude it from the sitemap at the same time. This means a Collection Default is either enabled and the sitemap excluded, or disabled with the sitemap enabled.

Both can be on at the same time, but not off.

from seo-pro.

benwellby avatar benwellby commented on July 21, 2024

Is anyone else experiencing this… in Section defaults, not being able exclude a collection from both a generated sitemap 'and' the SEO Pro reports?

from seo-pro.

jackmcdade avatar jackmcdade commented on July 21, 2024

Are you running 2.10.7 and SEO Pro 1.1? I believe that's fixed now.

from seo-pro.

benwellby avatar benwellby commented on July 21, 2024

Just tested this with both of the updates (although SEO Pro was version 1.1.1).

No joy. Can't have both excluded from reports and sitemap :(

from seo-pro.

jasonvarga avatar jasonvarga commented on July 21, 2024

Just released 1.1.2 which fixes this.

from seo-pro.

benwellby avatar benwellby commented on July 21, 2024

That did fix it @jasonvarga.

The sitemap.xml outputs only pages and collections as specified, and reports are now accurate.

When the Section Default is disabled the sitemap options still show as enabled. Functionally this change works, but could have a slightly improved UX (by disabling sitemap options too).

Great work chaps.

Thanks

from seo-pro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.