Channel switching strobe modes have issues at ramp levels >130 about anduril2 HOT 5 CLOSED

Thank you for this feedback and proposed solution! I'll see what I can do when I have some time.
Thanks for using this fork too. Feel free to take whatever you like to yours as well!

from anduril2.

Fixed it in my version, backported: #21

from anduril2.

Hi @SiteRelEnby I finally got some time to review this. My apologies. I have got 2 busy little girls to deal with every day after work so less time now for Anduril2. Thanks for the excellent fix in this PR. Your code works perfectly.

However on my (limited numbers of) dual channel lights I don't see a benefit of going above RAMP_SMOOTH_CEIL (130) even in smooth alternating mode. Maybe it works better in some LED combinations. I hope you don't mind I won't merge the PR. I will however adopt your proposed fix so the max level user can go is 130, for both alternating modes.

Your fork that has direct shortcuts to 200% and both 100% turbo modes is brilliant. Since I'm getting more dual/multi channel Anduril2 lights, I might copy that over here :P

Thank you again.

from anduril2.

Awesome, thank you! I will need to find some time to check this!

from anduril2.

Yeah, no problem there, I like it with my white/red light although it's less useful on flood/throw. I'm keeping my fix in my version, or maybe make it configurable once I'm finished with LT1S Pro support.

from anduril2.