Comments (3)
This will also require changing / removing the copy-to-s3 behavior, since it writes to an S3 bucket at dist/{{ env.BRANCH_NAME }}
and could overwrite dist/main
...
from mapbox-gl-style-diff.
Ah this is a great point. I think it makes the most sense to remove that Github Action here since this is now a module and is not specific to the Amazon project bucket where this is currently getting copied.
We can copy this to S3 from the Amazon repo (and make whatever other hardcoded link changes we need). I think we can technically copy it from the module import if we don't exclude it or we could have the standalone tool live in that repo.
@ebrelsford what do you think makes sense?
from mapbox-gl-style-diff.
main
is the default branch now.
from mapbox-gl-style-diff.
Related Issues (12)
- Use a layer metadata property to track layers HOT 1
- Add UI for style switching
- diff sources in stylesheet
- more granular diffing for expressions HOT 4
- Tests HOT 1
- Detect and distinguish changes that have no visual result HOT 1
- Turn this repo into module HOT 1
- Move viewer to its own repo and remove copy-to-S3 script HOT 1
- Different outputs between Chrome and Firefox HOT 2
- Clean up code base HOT 1
- Update sources not clear
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mapbox-gl-style-diff.