Duplicate task name should throw error about orquesta HOT 3 CLOSED

This is actually a harder problem than it seems. The YAML parser that converts the WF definition to JSON will silently ignore the duplicate keys and take the last one. Currently, orquesta parses the WF definition pretty early on, way before any inspection takes place. So by the time, it inspects the definition, the duplicate key is already resolved by the YAML parser.

from orquesta.

Ah, I wondered if that might be the case. I've seen something similar with other places where we go YAML -> JSON internally.

from orquesta.

For documentation purposes, I was able to error on duplicate with the solution suggested at https://gist.github.com/pypt/94d747fe5180851196eb. However, since the YAML is parse very early on in the process and the inspection is using the resultant JSON, I don't have an elegant solution yet where the error is displayed as an entry in the inspection result. Also, the solution add the constructor into the Constructor and SafeConstructor classes and I don't see a method to remove the constructor after I identified the duplicate tasks.

from orquesta.