Add support for payment in the preview iframe about webcontainer-core HOT 12 CLOSED

Oh, this is very interesting! Thanks for opening the bug report 🙏 ! You are right, we will have to allow it. If you directly update the iframe with an allow="payment" attribute in the dev console, it seems to work fine. This shouldn't be hard to add :).

from webcontainer-core.

@socsieng alright, should be live 😀 !

from webcontainer-core.

Also @socsieng if you click the "open in new window" at the top of the page this should also fix the problem, as it's no longer running in an iframe :)

from webcontainer-core.

Also @socsieng if you click the "open in new window" at the top of the page this should also fix the problem, as it's no longer running in an iframe :)

Yes, I'm aware. However, I included the instruction in the demo because I don't think many developers will know that the button behaves differently in a new window/preview. If the button behaves correctly, then I can remove the prompt altogether.

from webcontainer-core.

I created an internal PR to fix this. Not sure when it will land though. Probably Monday, latest.

from webcontainer-core.

Thanks for the quick turnaround @SamVerschueren.

Do you know if this will also be applied to non webcontainer instances in StackBlitz?

See https://stackblitz.com/edit/google-pay-react for example.

from webcontainer-core.

It's a different part of the project so should be fixed separately. I'll see if I can take a look at it today or maybe tomorrow. Feel free to ping me back if you haven't heard anything from me at the end of the week.

from webcontainer-core.

@socsieng It should be live for non-webcontainer projects now as well 🙏 .

from webcontainer-core.

Thanks for the update @SamVerschueren.

I did some initial testing and found that it isn't working in Chrome 90.0.4430.212.

From what I can tell, the allow attribute is set to geolocation; microphone; camera; payment; which looks correct, however, when compared to the web-container version geolocation; microphone; camera; payment, the only difference is the trailing ;. When I remove the trailing semicolon from the allow attribute, and reload the iframe, it works as expected.

The ask is to remove the trailing semicolon.

I'm happy to file a separate issue. Is there a repo or a separate process to do this?

from webcontainer-core.

Mmm, this is super weird. I tested this before I deployed it to production but when trying it again now, it doesn't seem to work. I'll fix it 👍 .

from webcontainer-core.

@socsieng I tried fixing it, and although it seemed to work on our staging environment, it doesn't work on production. I have no clue what's going on (yet). Could you maybe create a new issue for it in https://github.com/stackblitz/core? That's where we track issues for non-WebContainer projects.

from webcontainer-core.

Will do. Thanks.

from webcontainer-core.