Git Product home page Git Product logo

Comments (13)

SamVerschueren avatar SamVerschueren commented on August 28, 2024 8

ESM is now supported but we found a bug when testing SvelteKit. There’s an open internal PR to resolve that so stay tuned!

from webcontainer-core.

EricSimons avatar EricSimons commented on August 28, 2024 4

@franxois we're still WIP on getting a few fixes in that will enable SvelteKit, the team will circle back here once these updates hit production.

from webcontainer-core.

KwintenP avatar KwintenP commented on August 28, 2024 2

@guidobouman npm init has an open issue in #2
@EricSimons we are using #6 to track esm module support

from webcontainer-core.

KwintenP avatar KwintenP commented on August 28, 2024 1

A bug for sure. Like you said, very likely related to #8 which has been on our roadmap for sure.

from webcontainer-core.

EricSimons avatar EricSimons commented on August 28, 2024 1

@jthegedus ah I didn't realize Vite was relying on ESM too- good catch. 🙏

@KwintenP maybe we create a root issue for enable node.js es modules support that both this issue and #8 reference as prerequisites?

from webcontainer-core.

guidobouman avatar guidobouman commented on August 28, 2024 1

Probably redundant, but just in case: Initialising a project with npm init does not seem to work. There's some sort of hook that does not expect the extra arguments, and tries to run turbo.

❯ npm init svelte@next test
Unknown Syntax Error: Extraneous positional argument ("svelte@next").

$ turbo create [-p,--private] [-w,--workspace] [--cwd,--prefix #0] [-s,--silent] [--quiet] [-V,--verbose] [--loglevel #0]

error Command failed with exit code 1

Once a SvelteKit example is setup, this is of course not needed anymore.

from webcontainer-core.

guidobouman avatar guidobouman commented on August 28, 2024 1

@milky2028 see #2 (comment) for more info. npm init was fixed, now they're on a level lower: git.

from webcontainer-core.

d3lm avatar d3lm commented on August 28, 2024 1

Hey ya'all 👋

We have pushed several fixes that now unlock SvelteKit on StackBlitz. Here's an example. However, npm init still doesn't work because we are still working on our git internals and CLI.

from webcontainer-core.

EricSimons avatar EricSimons commented on August 28, 2024

SvelteKit also uses ESM for their package, no CJS, so that will need to be enabled as well. We might need to open a separate ticket for ESM support specifically

from webcontainer-core.

jthegedus avatar jthegedus commented on August 28, 2024

I thought ESM was a requirement for Vite and thus captured in #8

from webcontainer-core.

jthegedus avatar jthegedus commented on August 28, 2024

Yes, npm init does not work and I had to manually setup each of the resources in the linked example. Ideally turbo would support these commands.

from webcontainer-core.

milky2028 avatar milky2028 commented on August 28, 2024

I'm getting errors here as well, but instead getting:

Command failed: git ls-remote https://github.com/Axelen123/svelte-component-template
jsh: command not found: git

Great choice! Generating your Svelte app... !
 ›   Error: Something went wrong, try again! Error: could not find commit hash for 
 ›   master

from webcontainer-core.

franxois avatar franxois commented on August 28, 2024

When I saw the tweet about vite.js, I try sveltekit from an existing repository but it doesn't work https://stackblitz.com/github/franxois/svelte-kit-demo-app

from webcontainer-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.