Comments (11)
I don't have a strong opinion on this, so I'd tend to agree with you, unless somebody thinks this is a good idea. I suggest to wait a couple of days to make sure nobody is against this for some good reasons, and then you can change it.
from tsid.
I think the naming pos, vel and acc are misleading in fact. Another naming would be expected here I would say.
from tsid.
Maybe we could replace vel
with rate_of_change
? But what could we use to replace pos
? And acc
?
from tsid.
It could be value
, time_derivative
,
time_second_derivative
?
from tsid.
I like value
! Maybe I'd go for first_time_derivative
and second_time_derivative
though.
from tsid.
Yes, I do agree that value
seems more appropriete.
from tsid.
@pFernbach Do you plan to do the PR? Or should I do it instead?
from tsid.
Sorry I forgot about, I'll do it next week. Do you confirm the following changes:
- rename
TrajectorySample::pos, vel, acc
tovalue, time_derivative, second_time_derivative
- Adapt all the C++ code
- Set the current python API with
pos, vel, acc
deprecated and add a new one withvalue, time_derivative, second_time_derivative
from tsid.
Yes, that was the plan, but now that I think about it, since a trajectory is a function of time only, maybe we don't need to specify that the derivatives are wrt time. Therefore, we could simplify the names to value, derivative, second_derivative
. What do you think?
from tsid.
Yes it make sense, I don't think that there could be any confusion.
from tsid.
Shall we close this now?
from tsid.
Related Issues (20)
- contact-6D: unclear - could be pulling force ? HOT 6
- ForceTask with moving object HOT 11
- GitHub Action HOT 3
- Cannot surpress SolverHQuadProg output HOT 3
- TaskJointPosVelAccBounds not exposed to the python API HOT 3
- Adding equality constraints between joints HOT 9
- Test optional dependencies during CI HOT 1
- conda install broken ? HOT 4
- undefined symbol error in libtsid_pywrap.so HOT 2
- SE3 Inequality Task or Constraint HOT 1
- Large time steps HOT 4
- github action on OSX conda Release failing on osqp solver HOT 2
- TSID Performance Issue, slow HQP solves HOT 9
- Does it contain c++ examples? HOT 4
- auto formating precommit hook HOT 1
- display error
- Plans for Pinocchio3.x integration? HOT 3
- build issue with catkin build ROS1 HOT 6
- Python Binding for TaskActuationEquality HOT 4
- Compatibility Issue with Latest Pinocchio Version and TSID HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tsid.