Comments (21)
Hi @nim65s , after a quick look at the (really) long discussion you had with the others, I wonder whether this really concerns me and TSID. TSID depends on pinocchio, but not on FCL because it doesn't use the collision checking features. So, should I be concerned with this discussion?
To answer your question I think TSID is ready for a new release, using the branch pinocchio_v2, which you can merge into master.
from tsid.
Regarding the BSD license issue #20, TSID contains the software eiquadprog which is under GPL. This might be an issue, doesn't it?
from tsid.
Thanks for your answers. If the branch pinocchio_v2 is ready, this is all we need.
from tsid.
@andreadelprete When the planning messed up (or when there is no planning) avoiding collision in the control is the nice feature...
Yes having eiquadprog inside TSID is an issue.
from tsid.
@olivier-stasse I will provide a solution for that as soon as possible to remove the strong dependency on EiquadProg.
from tsid.
@andreadelprete When the planning messed up (or when there is no planning) avoiding collision in the control is the nice feature...
sure, eventually it would be nice to add collision avoidance in TSID. I only meant that currently it's not there, so TSID wouldn't be affected by any change in HPP-FCL.
from tsid.
Regarding the compatibility with pinocchio-v2 I worked on a PR to update the library to pinocchio-v2.1.0.
I made a mistake and pushed directly on devel instead of my PR. Let me know if this is a problem, I will revert it if needed.
from tsid.
Hi @olivier-stasse, as far as I know TSID is already compatible with Pinocchio-v2. At the very least the branch pinocchio-v2
is. Moreover, @nim65s should have merged that branch into master a few weeks ago, so even master should be aligned with pinocchio-v2 now.
from tsid.
Actually after a quick look at the code it seems that it is devel
to be aligned with pinocchio-v2. Master is still on pinocchio-v1.
from tsid.
Hi @andreadelprete. I did some tests today and some stuff were not working. For instance there was a lot of se3 namespace instead of pinocchio.
from tsid.
And i am talking about the devel branch. But maybe I missed something
from tsid.
#25 changed the namespace, but in master instead of devel.
I will handle that tomorrow, and make a release of TSID.
from tsid.
Ok, sorry my bad. Looking at #25, it seems that the branch pinocchio_v2 doing the right fix was not merged into devel.
from tsid.
@nim65s
I'll try to compare with the branch pinocchio_v2
from tsid.
@olivier-stasse So do you want to handle the merge in #33 ?
from tsid.
Or should we just forget about either the pinocchio_v2 branch, or @olivier-stasse 's last commits to devel ?
from tsid.
Well… For me, pinocchio_v2 branch is building (and tests are passing) and not devel, so I think I will use this one for the release.
from tsid.
Everything now looks good to me. @andreadelprete @olivier-stasse can you just review this commit: dab03d3 ?
from tsid.
Github overrides the link… You will have to go there #33 and then click on Merge branch 'devel' into pinocchio_v2
from tsid.
Everything now looks good to me. @andreadelprete @olivier-stasse can you just review this commit: dab03d3 ?
it looks good to me!
from tsid.
Good to me too
from tsid.
Related Issues (20)
- Alignment error with -march=native, fixed with c++17 HOT 3
- TSID for "pantograph/biarticular" robot leg design? HOT 6
- COP_Task - Looking for the 'romeo_walking_traj_tsid.npz' file. HOT 4
- posture task read error HOT 4
- contact-6D: unclear - could be pulling force ? HOT 6
- ForceTask with moving object HOT 11
- GitHub Action HOT 3
- Cannot surpress SolverHQuadProg output HOT 3
- TaskJointPosVelAccBounds not exposed to the python API HOT 3
- Adding equality constraints between joints HOT 9
- Test optional dependencies during CI HOT 1
- conda install broken ? HOT 4
- undefined symbol error in libtsid_pywrap.so HOT 2
- SE3 Inequality Task or Constraint HOT 1
- Large time steps HOT 4
- github action on OSX conda Release failing on osqp solver HOT 2
- TSID Performance Issue, slow HQP solves HOT 9
- Does it contain c++ examples? HOT 4
- auto formating precommit hook HOT 1
- display error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tsid.