Use proper sql parser about phpstan-dba HOT 5 OPEN

I don't have any real examples, but how about?

• SELECT * FROM cmsdomain WHERE url LIKE "%?%";
• SELECT * FROM cmsdomain WHERE url LIKE "%:tag_name%";
• SELECT * FROM cmsdomain WHERE cmsdomainid IN (1,2) /* What about 3? */
• SELECT * FROM cmsdomain WHERE 1=2; -- :TODO?

from phpstan-dba.

Might be worth looking at the PDO function that parses parameters, to see how it works.

It seems to use pdo_parse_params(), which is a bit more complicated than using the BINDCHR regex by itself (used later as PDO_PARSER_BIND).

It supports escaped question marks (??), comments (/* What about X? */ or -- To fix?), and quoted string values (see ANYNOEOF?).

from phpstan-dba.

Would be great if you could provide failling testcases if you have special cases in mind

from phpstan-dba.

I don't have any real examples, but how about?

* `SELECT * FROM cmsdomain WHERE url LIKE "%?%";`

* `SELECT * FROM cmsdomain WHERE url LIKE "%:tag_name%";`

* `SELECT * FROM cmsdomain WHERE cmsdomainid IN (1,2) /* What about 3? */`

* `SELECT * FROM cmsdomain WHERE 1=2; -- :TODO?`

these basic examples are now covered by #145

still on the long run we might better use a sql parser. lets see whether people report problems with their queries when running phpstan-dba on real projects

from phpstan-dba.

on twitter the SQLFTW/sqlftw project was suggested as a proper parser

from phpstan-dba.