Comments (9)
Have you tried to use the gl-react-image component inside?
from gl-react-imagefilters.
Yes I did - I found no difference in performance (in fact it may have been a little worse).
from gl-react-imagefilters.
wierd, it works just fine on a s6 and s4 with android..
could you try to attach the sliders to seperate variables and then pass them into the component?
changing a object state with all parameters will probably trigger react to rerender every child component in gl-react instead of only the slider that changed.
are you also using native sliders or custom UI sliders? (i have used custom ones and they made it all pretty slow on Android)
from gl-react-imagefilters.
I'm testing on an iPhone 6s+, iPhone 6s, and iPhone 5. I haven't tried it on Android. I'm using native sliders. My filter variables are stored in an object as described above. I am using the immutability helper (https://facebook.github.io/react/docs/update.html) to update the state of the particular key I'm trying to update with the slider. How else do you recommend structuring this for it work?
from gl-react-imagefilters.
I guess you are running the full set of functions including shouldComponentUpdate() and so on?
To be shure that there is a problem preformance wise it would be in gl-react
as this is just a component that renders multiple GLNodes. Using one or multiple GLNodes does not affect the preformance in any way.
Could you try to create a plain simple component with a state for every params and run it?
As i have experienced running on iPhone is alot faster than Android, and even running on a old Samsung S4 is fast here.
There may be be a performance issue in your code somwhere.
I dont have a iPhone to test with here right now. so that i would have to test out next week.
from gl-react-imagefilters.
Cool I will try it - thanks for the advice. It's good to know that nesting multiple nodes doesn't affect performance in any way.
from gl-react-imagefilters.
np, let me know if it works out with a plain plugin
from gl-react-imagefilters.
@sscaff1 got it working?
from gl-react-imagefilters.
closing thisone as it is aged, no response..
Please update ticket if you still experience problems..
from gl-react-imagefilters.
Related Issues (13)
- RN Project fails to run when this lib is a dep HOT 14
- An in-range update of gl-react-temperature is breaking the build 🚨 HOT 2
- undefined is not a object HOT 4
- Publish latest changes to npm HOT 4
- Dependencies issues HOT 5
- Can't find variable: Component HOT 7
- Documentation mentions Sepia twice with different defaults HOT 1
- Version 10 of node.js has been released
- An in-range update of semantic-release is breaking the build 🚨 HOT 13
- Undefined is not an object (evaluating '_glReact2.default.createComponent') HOT 4
- How to export the image with filters? HOT 3
- Do i have to install gl-react and gl-react-native to make this work? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gl-react-imagefilters.