Comments (6)
0.1.10 works great. Thanks!
from react-rte.
@simpixelated: I just pushed 0.1.11 which includes CSS Modules (requiring me to change the build system again). Let me know if this breaks anything for you. Thanks!
from react-rte.
So after doing some more investigation. I found the solution: https://gist.github.com/jimfb/4faa6cbfb1ef476bd105#gistcomment-1686426
Still not sure if the problem is in webpack, npm link, or a combination of the two. But by moving react/react-dom to peerDependencies in react-rte and then updating webpack.config with the new resolves, I was able to get this working. It's still very finicky though.
from react-rte.
Thanks @simpixelated! I know there is not really any guidance about getting this working in a project right now (hence the readme says Note: this is in early stage development. Do not use yet.
) so I'm impressed you were able to make it happen. I'm looking at your changes and I'll pull in most of these and also make a section in the README describing how to use this editor.
A few comments about your changes:
- You shouldn't need
transform-flow-strip-types
in your babel config.babel-preset-react
includes this plugin. - I don't suggest checking in the compiled files to git although they should be in the npm package.
- I think we should move all the dependencies to devDependencies with the exception of react/react-dom which should be peer dependencies
I'll get these changes in master.
Thanks!
EDIT: I realized you already fixed peerDependencies.
from react-rte.
Awesome, thanks for the quick feedback and for mentioning me in your commit/package.json! One other issue I ran into, is that the absolute paths in the CSS imports prevented me from importing them via webpack. I created a pull request which fixes the issue for me: #9
from react-rte.
This should be working now. Let me know if there's any other issues. Thanks.
from react-rte.
Related Issues (20)
- Appending custom html in the editor
- Warning: componentWillUpdate has been renamed HOT 2
- read the length of value
- How can I update the paste value while pasting it on rich text editor.
- converting between HTML and MD
- Is there any documentation for this?
- Add React 18.x.x HOT 4
- Show URL link on links hover
- Autofocus not working as expected with React hook forms
- How to get WYSIWYG when images are used
- Many newlines causes editor to go into an infinite loop
- Command for new line
- Size of the bullet points has not changed along with texts font sizes
- Not working on JSX
- Jumping cursor on mobile HOT 1
- ReferenceError: window is not defined HOT 1
- Window is not defined error when run from Next HOT 2
- react-rte dependency issue with [email protected] HOT 2
- Not working react-rte HOT 2
- While adding an empty link in popover, it redirects to home url when clicked
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-rte.