Git Product home page Git Product logo

Comments (4)

sstur avatar sstur commented on August 26, 2024

I found an issue where the show/hide functions fire endlessly. I'll fix that and push an update. Are there any other issues you can see with 4.1.1?

Update:
The commit that seems to have broken it is this:
ckeditor/ckeditor4@0a2b80c

The code in my plugin that gets broken is:
https://github.com/sstur/ck-webkitdrag/blob/v0.2.1/plugins/webkitdrag/plugin.js#L330-338

There's something funky going on where editor.forceNextSelectionCheck() or editor.selectionChange() causes beforeUndoImage/afterUndoImage to fire. This causes an endless loop. I'll try to come up with a fix..

from ck-dragresize.

pierrocknroll avatar pierrocknroll commented on August 26, 2024

Yeah, I found the same bug, I don't see other issues in 4.1.1.

Thanks

from ck-dragresize.

sstur avatar sstur commented on August 26, 2024

Fixed in 9fc0792

from ck-dragresize.

pierrocknroll avatar pierrocknroll commented on August 26, 2024

Cool! Merci beaucoup :)

from ck-dragresize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.