Comments (6)
Hanksha
commented on July 29, 2024
This is the launch config generated by lcdsl:
from lcdsl.
mduft
commented on July 29, 2024
This seems to be a bug in LcDsl indeed. I can reproduce it with /some/ products, but others work.
From what I can tell until now there seems to be some shortcut logic that IF the product name contains dots (?), the bundle name is not prefixed to the product name, otherwise it should be prefixed with the bundle name :|
You could verify this by renaming your product to just 'product' - it should then be correctly identified both by eclipse and LcDsl as io.toro.coder.branding.product If you can confirm this, I can create a fix.
from lcdsl.
Hanksha
commented on July 29, 2024
Yes I confirm, if the product id is just product then the generated config with io.toro.coder.branding.product has no warning.
from lcdsl.
Hanksha
commented on July 29, 2024
By the way, not sure if it's related but, if I have an invalid .lc file like this:
And run it from the Launch Configurations view I get an NPE:
java.lang.NullPointerException
at org.eclipse.debug.ui.launchview.launcher.StandaloneLaunchConfigExecutor$StandaloneLauncherJob.<init>(StandaloneLaunchConfigExecutor.java:192)
at org.eclipse.debug.ui.launchview.launcher.StandaloneLaunchConfigExecutor.launchProcess(StandaloneLaunchConfigExecutor.java:53)
at com.wamas.ide.launching.ui.launchview.LcDslLaunchObject.launch(LcDslLaunchObject.java:96)
at org.eclipse.debug.ui.launchview.internal.view.LaunchAction.run(LaunchAction.java:78)
at org.eclipse.debug.ui.launchview.internal.view.LaunchViewImpl.lambda$1(LaunchViewImpl.java:130)
at org.eclipse.jface.viewers.StructuredViewer$1.run(StructuredViewer.java:831)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.JFaceUtil.lambda$0(JFaceUtil.java:44)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
at org.eclipse.jface.viewers.StructuredViewer.fireDoubleClick(StructuredViewer.java:828)
at org.eclipse.jface.viewers.AbstractTreeViewer.handleDoubleSelect(AbstractTreeViewer.java:1459)
at org.eclipse.jface.viewers.StructuredViewer$4.widgetDefaultSelected(StructuredViewer.java:1258)
at org.eclipse.jface.util.OpenStrategy.fireDefaultSelectionEvent(OpenStrategy.java:249)
at org.eclipse.jface.util.OpenStrategy.access$0(OpenStrategy.java:247)
at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:306)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4258)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1502)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1525)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1510)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1314)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4082)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3699)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1150)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1039)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
at org.eclipse.equinox.launcher.Main.run(Main.java:1499)from lcdsl.
mduft
commented on July 29, 2024
An updated version is available from the update site (caches could take a few minutes). Could you please update and try it? Fixed version is 0.1.2.N201811231318
from lcdsl.
Hanksha
commented on July 29, 2024
It's working now, the config is valid and I can launch it. But I noticed that I have no more content assist/auto completion for the product names.
Also, but it's really a minor thing, it didn't detect automatically that the product used for the launch config needed a feature containing the org.eclipse.ui.ide.workbench application as per my plugin.xml defining the product.
from lcdsl.
Related Issues (20)
- new feature: Link to products / features / plugins HOT 3
- Provide default ID for launch config
- new feature: Add required dependencies HOT 3
- Working Sets HOT 1
- Easy access to raw launch configuration file HOT 1
- Missing ignored plugins should not generate a warning
- Updating the Xtext Community Website HOT 3
- NPE with unknown launch types HOT 5
- Missing latest version of org.eclipse.debug.ui.launchview HOT 2
- Startlevels for workspacebundles HOT 6
- Test class not accepting all JUnit5 variants HOT 1
- Support launch type pure JUnit? HOT 1
- Application `[No Application] - Headless Mode` unsupported. - Should be default HOT 1
- regression: CI build hangs at "loading target platform" HOT 3
- Validation for test class is too strict
- Compile error due to using API 11, but 1.8 on classpath HOT 1
- Introduction of variables in lcdsl
- Test container plugin dependencies should be added automatically
- Plugins attribute should not be required if test container points to a plugin project
- Typing `${folder_prompt}` in `working-dir` crashes the IDE
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lcdsl.