Git Product home page Git Product logo

Comments (5)

sseemayer avatar sseemayer commented on August 10, 2024 1

Sounds great, let's do it! 💪

regarding coding style in Rust, there is rustfmt. Just

  1. run rustfmt on the codebase before you do any work
  2. if there are changes, commit them separately
  3. do your changes in any coding style you like
  4. run rustfmt again
  5. commit

from keepass-rs.

sseemayer avatar sseemayer commented on August 10, 2024 1

Regarding the issue itself, let's do #29 first and then follow up with this issue.

from keepass-rs.

sseemayer avatar sseemayer commented on August 10, 2024

Thanks for filing the issue! Probably, there is some difference in the XML formats betwen KDBX3 and KDBX4 that I was not yet aware of.

from keepass-rs.

sseemayer avatar sseemayer commented on August 10, 2024

As a heads-up, I am in a state of being constantly very busy with my day job, so I might not be able to do much troubleshooting on this right now. It might take me some time to fix this.

keepass-rs was one of my first real Rust projects, and I learned a lot in writing it. If you want to take a stab at fixing this yourself, I do think that I would have enough time to mentor.

from keepass-rs.

jgrussell avatar jgrussell commented on August 10, 2024

I think I have found my issue with pulling ExpiryTime from the database for #29 at the very bottom of the official KDBX 4 documentation page:

In encrypted KDBX 4 files (not in plaintext XML exports), all times are now stored as Base64 string of the Int64 number of seconds elapsed since 0001-01-01 00:00 UTC. This improves the performance and reduces the file size.

Note: The file formats look the same when saved/exported as unencrypted XML!

@sseemayer,
I would love to take you up on the mentoring offer as your availability permits. I think I am getting close to having something presentable via a Draft PR for addressing #29 and will definitely appreciate any corrections, commentary, suggestions, etc. I have tried to follow your coding style for a few reasons:

  • This is my first Rust coding (also my first GitHub experience) of any significance; and, assuming we complete it, my first real Open Source project contribution.
  • I am a firm believer that coding styles should at least be consistent within modules, ideally within projects.
  • Hopefully, this will make the code and any later maintenance easier.

Maybe I can track down the KDBX4 issue with Entry::AutoType.sequence after that.

Thank you again!

from keepass-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.