Git Product home page Git Product logo

Comments (6)

sscarduzio avatar sscarduzio commented on May 21, 2024

Many people have shown interest for 1.x compatible version of this plugin. That's why I keep a 1.x branch!
Have you seen it? However I saw it working down to 1.5.3, but didn't try with 1.4.
It would be nice if you could have a look there and fill some gaps if you find anything.

And yes, I should advertise more about the availability of a 1.x branch.

from elasticsearch-readonlyrest-plugin.

pciccarese avatar pciccarese commented on May 21, 2024

I just looked at it now but I don't think that works for 1.4.4 as the process for the registration of Actions and Filters was different. The onModule call in the *Plugin main class was not working on 1.4.4 I believe. Or at least I was not able to get it to work :)

Your call, 1.4.4 would probably sit on yet another separate branch.

from elasticsearch-readonlyrest-plugin.

sscarduzio avatar sscarduzio commented on May 21, 2024

Ok let's do this! How far backwards does this go?
We could publish builds for a few major pre-1.5 versions quite easily, I reckon.

It will be quite easy to support because the code is only slightly different.

I'll branch out the current master tomorrow so you'll be able to make a pull request against that.

from elasticsearch-readonlyrest-plugin.

pciccarese avatar pciccarese commented on May 21, 2024

I've tested only 1.4.4. I am assuming any 1.4.x will work. I cannot tell about versions previous to that one.

from elasticsearch-readonlyrest-plugin.

sscarduzio avatar sscarduzio commented on May 21, 2024

No worries, I have this docker+newman based integration test system in place I can smoke-test a few versions and make some builds.

_S

On 29 Mar 2016, at 16:37, Paolo Ciccarese [email protected] wrote:

I've tested only 1.4.4. I am assuming any 1.4.x will work. I cannot tell about versions previous to that one.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub #32 (comment)

from elasticsearch-readonlyrest-plugin.

sscarduzio avatar sscarduzio commented on May 21, 2024

Hey @pciccarese @paolociccarese, I created a pre-1.5 branch, if you're still OK for that pull request? :)

from elasticsearch-readonlyrest-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.