Thanks for looking into the code and making a recommendation.

This function already is a loop, and .id performs faster than jquery .attr()

from andi.

I'm talking about "AndiOverlay.prototype.overlayTableMarkup" in line 1533. The for loop would replace the if statements: "if(role)", "if(id)", "if(headers)", and "if(scope)".

from andi.

Difference in the code:

Original Code ""

scope = $(this).attr("scope");
headers = $(this).attr("headers");
id = this.id;
role = $(this).attr("role");

markupOverlay = $(this).prop("tagName").toLowerCase();

if(role)
markupOverlay += " role=" + role;
if(id)
markupOverlay += " id=" + id;
if(headers)
markupOverlay += " headers=" + headers;
if(scope)
markupOverlay += " scope=" + scope;

New Code

NOTE: markupOverlay would be moved out of the $("#ANDI508-testPage [data-tandi508-colindex]").each(function() area

var attributesToFind = ["scope", "headers", "id", "role"];
for (var a = 0; a < attributesToFind.length; a++) {
var attributeValue = $(this).attr(attributesToFind[a]);
if (attributeValue) {
markupOverlay += attributesToFind[a] + "=" + attributeValue;
}
}

from andi.