Git Product home page Git Product logo

Comments (4)

srishanbhattarai avatar srishanbhattarai commented on August 27, 2024

Hi, thanks for taking this!

I am hesitant about landing #35 because it breaks some downstream projects and I might even close it. It's been in limbo for a while now and I've been slacking off 😞

I would recommend that you create your PR off of the current head instead of waiting for #35.

from nepcal.

axispx avatar axispx commented on August 27, 2024

Sure I can do that. I wanted to wait for #35 because it seems to have better structure overall and some kludgy parts of the code could be weeded out. Thanks.

from nepcal.

srishanbhattarai avatar srishanbhattarai commented on August 27, 2024

Fully agree but having downstream projects is what's stopping that from landing. The project's goals have changed from its genesis so there is a lot of weeding out that needs to happen.

To me, the best way forward seems to be to create a v2/ library with the niceties in #35. But for this issue, I'd be grateful if you just went with whatever is present.

from nepcal.

axispx avatar axispx commented on August 27, 2024

Closing since #41 is merged.

from nepcal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.