Support Other CGI Modules about simpleshib HOT 2 OPEN

Hi @jrchamp and @cjbnc,

I believe e0d52eb should fix this issue by allowing the customization of attributes. Could you take a look and let me know if it addresses the issue?

Thanks!
Steve

from simpleshib.

The two functions referencing the private member variable should use $this->Attributes.

By customization, you still mean "edit the code to set new hardcoded values". It's in one place instead of two now, but that does not reduce the overall level of difficulty to maintain across disparate systems.

As far as addressing the issue, I would say 'no'. We use a standard configuration for the Shibboleth attributes and this Issue is about supporting multiple modules simultaneously, so by not applying the same transformations as in the original patch to the configured attributes names, it cannot work for multiple modules without also making changes to the code to match the chosen module.

from simpleshib.