Git Product home page Git Product logo

Comments (6)

titobf avatar titobf commented on May 28, 2024

I agree that would be nice to have that feature. Recently, I had to detect IE versions and at first I thought that this module would be helpful, but instead I ended up using this solution from haizpt: http://stackoverflow.com/a/27221924/1454888 (wrapping that code in a service)

from ng-device-detector.

srfrnk avatar srfrnk commented on May 28, 2024

Hi @bensquire, @titobf,

I'm trying to exactly define the user-case in your request.

From what I can tell you mostly need OS version for windows (e.g. windows edition) and IE version.
Is that correct?

For example would it really serve a purpose to have chrome version? a FF version? Linux edition/version?

It would change much if we are talking about supporting version for all browsers/OS/devices vs. only adding IE + Win versions.

10x for your feedback,
Shahar.

from ng-device-detector.

bensquire avatar bensquire commented on May 28, 2024

From our point of view, we currently use this information for user statistics (as opposed to changing the visuals of the site).

So ideally it wouldn’t be just IE/OS version, but when possible any browser/OS version.

Thanks
Ben

On 11 Feb 2015, at 15:10, Srfrnk [email protected] wrote:

Hi @bensquire https://github.com/bensquire, @titobf https://github.com/titobf,

I'm trying to exactly define the user-case in your request.

From what I can tell you mostly need OS version for windows (e.g. windows edition) and IE version.
Is that correct?

For example would it really serve a purpose to have chrome version? a FF version? Linux edition/version?

It would change much if we are talking about supporting version for all browsers/OS/devices vs. only adding IE + Win versions.

10x for your feedback,
Shahar.

—
Reply to this email directly or view it on GitHub #18 (comment).

from ng-device-detector.

titobf avatar titobf commented on May 28, 2024

In our case, we just need to check the version of Internet Explorer.

from ng-device-detector.

srfrnk avatar srfrnk commented on May 28, 2024

Added both os version and browser version.
Supporting windows versions only for now.
Added support for IE, Chrome, FF and Opera versions.
Please feel free to add more support on top of the new mechanism... but please add tests when you do.
Enjoy :)
10x,
Shahar.

from ng-device-detector.

titobf avatar titobf commented on May 28, 2024

Great Shahar! I'm sure this will be very useful. I'll try the new version.

from ng-device-detector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.