Git Product home page Git Product logo

Comments (7)

JakeWharton avatar JakeWharton commented on July 30, 2024

This means you can no longer use it in base classes.

from otto.

loganj avatar loganj commented on July 30, 2024

You mean base classes couldn't safely do bus.register(this)? I'm ok with that. It seems wrong if this may or may not actually even want to be on the bus.

from otto.

JakeWharton avatar JakeWharton commented on July 30, 2024

That is inevitable. You register/unregister in a base activity and base fragment. Eventually you will have one with no methods but a ton of other shared architecture.

from otto.

loganj avatar loganj commented on July 30, 2024

So use another base class or a marker interface or a class-level annotation, to either opt in or opt out of bus registration. If we don't throw, we're passing up an opportunity to catch a mistake.

from otto.

 avatar commented on July 30, 2024

I'm with @JakeWharton on this one. Correctness is nice and everything, but this is going to force contortions for little gain. -1

from otto.

loganj avatar loganj commented on July 30, 2024

paging @pyricau

from otto.

pyricau avatar pyricau commented on July 30, 2024

close close close. Sorry. Bad idea.

from otto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.