Error on service hook update. about kochiku HOT 3 CLOSED

What do you think we should do in this situation? Blindly overwrite the hook id stored in the database with the new one?

@nolman what do you think about this?

from kochiku.

@robolson

Ya we could update GithubPostReceiveHook#subscribe! to always use the #synchronize_or_create! strategy and overwrite. The downside of doing this as the @interested_events change we will leave behind hooks. So we would need to clean up those leftover hooks.

We could also update RepositoryObserver#after_save to handle errors and save the error message when installing a hook fails.

@jdavisp3 would you be able to provide more context on how the GH instance and kochiku got into this state? As well as what hooks currently exist (as well as your kochiku hostname)? Just trying to understand the what happened from a end users perspective.

from kochiku.

I'm not exactly sure how I got into this state, but it happened a few times.
I think one time it happened I moved the repo URL to point to a different
repo -- I guess the hook it was expecting wasn't there maybe?

The other time I think I was debugging a hook problem on my (networking)
and I was editing the hooks by hand to find one that worked, so I probably
deleted the original one?

from kochiku.