Git Product home page Git Product logo

Comments (3)

nene avatar nene commented on July 22, 2024

Given than FETCH is equivalent to LIMIT, the last example looks fine to me. With LIMIT you'd get:

SELECT
  supplier_name,
  city
FROM
  suppliers 
LIMIT 
  2

An alternative would be to add full "FETCH FIRST" to reservedToplevelWords, so you'd get:

SELECT
  supplier_name,
  city
FROM
  suppliers 
FETCH FIRST
 2 ROWS ONLY

A separate question is whether we should improve the formatter to not break stuff like LIMIT 2 and FETCH FIRST 2 ROWS OWNLY to multiple lines.

PS After having written out this FETCH-FIRST-thing several times I'm not surprised most databases have opted for something shorter. It's surprisingly long thing to write to specify such a trivial thing.

from sql-formatter.

mathiaskissig avatar mathiaskissig commented on July 22, 2024
LIMIT
   2

and

FETCH FIRST
 2 ROWS ONLY

are correctly formatted according to our global formatting rules, but readability suffers.

I would prefer Joachim's example and even consider formatting LIMIT differently. E.g.

LIMIT 2
FETCH FIRST 2 ROWS ONLY

from sql-formatter.

nene avatar nene commented on July 22, 2024

For now added a fix to at least support the following formatting:

FETCH FIRST
    2 ROWS ONLY;

from sql-formatter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.