Comments (10)
"ethers": "^5.5.1"
I hope that works for you, then we can close this issue.
If I do npm install siwe@beta
the issue is fixed for me, Thanks!
from siwe.
from siwe.
ethers
is still hard coded to 5.5.1 on main
:
siwe/packages/siwe/package.json
Line 30 in 6a9a8a2
Unfortunately, ethers
v6 is now in beta and I believe it changes the public surface area a bit which might end up in things breaking if someone uses a v6
peer dependency. I don't know if NPM will allow major version changes to peer dependencies automatically with ^5.51
or not, but regardless of whether it does or not I think there needs to be a solution for the transition from ethers
v5 to v6, which is likely to happen very slowly across the ecosystem.
Having this library only work with v5 or only work with v6 is going to cause notable pain for some ever-changing portion of the developer base over time.
from siwe.
@safisaleem does this issue still exist? otherwise we will close this.
from siwe.
https://github.com/spruceid/siwe/pull/58/files fixed this in theory, but anyone using the npm registry will still have the issue because #58 doesn't seem to have been published yet
from siwe.
agree with what @joewagner said
from siwe.
ethers
is still hard coded to 5.5.1 onmain
:siwe/packages/siwe/package.json
Line 30 in 6a9a8a2
Unfortunately,
ethers
v6 is now in beta and I believe it changes the public surface area a bit which might end up in things breaking if someone uses av6
peer dependency. I don't know if NPM will allow major version changes to peer dependencies automatically with^5.51
or not, but regardless of whether it does or not I think there needs to be a solution for the transition fromethers
v5 to v6, which is likely to happen very slowly across the ecosystem.Having this library only work with v5 or only work with v6 is going to cause notable pain for some ever-changing portion of the developer base over time.
Thanks for the heads up here on a lot of this - we'll work to address!
from siwe.
This issue is fixed in our beta release of siwe 2.0.3. Now the dependency is:
"ethers": "^5.5.1"
I hope that works for you, then we can close this issue.
from siwe.
^
will only do minor and patch updates. It won't do major updates. You can do >5.5.1
would work, but I believe that ethers
6 is not fully API compatible with ethers
5, so I recommend testing before moving forward with this strategy.
from siwe.
^
will only do minor and patch updates. It won't do major updates. You can do>5.5.1
would work, but I believe thatethers
6 is not fully API compatible withethers
5, so I recommend testing before moving forward with this strategy.
@MicahZoltu Ok, we will close this issue and created a new one for ethers 6 upgrade path.
from siwe.
Related Issues (20)
- ncaught Error: No QueryClient set, use QueryClientProvider to set one
- TypeError: (0 , siwe_parser_1.isEIP55Address) is not a function HOT 1
- Cannot read property 'SiweMessage' of undefined HOT 2
- Invalid signature recovery are logged via console.error, breaking applications with custom logging flow
- Viem support? HOT 13
- isEIP55Address cannot be called because @spruceid/siwe-parser might be below 2.0.0 version HOT 3
- Suggestion regarding siwe-parser usage of apg-js. HOT 9
- Please provide CDN HOT 1
- Change Provider configuration to allow plain RPC URL property
- Cannot sign in with Argent wallet HOT 1
- Custom logo when authenticating, possible? HOT 4
- Crash on iOS 14 When Initializing SiweMessage Instance HOT 5
- I'm not getting the right address when checking HOT 3
- '"ethers"' has no exported member named 'providers' HOT 1
- Why version "2.1.4", requires SiweMessage.version to be 1? HOT 1
- Module parse failed: 'import' and 'export' may appear only with 'sourceType: module' (2:0) HOT 1
- Cloudflare Workers compatibility HOT 3
- invalid opts check is looking at the wrong array HOT 1
- update quickstart example code to include provider for 1271 support HOT 1
- Impossible to use siwe library due to issues with ethers v6 and v5. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from siwe.