ethers resolving to version 5.5.1 only about siwe HOT 10 CLOSED

"ethers": "^5.5.1"

I hope that works for you, then we can close this issue.

If I do npm install siwe@beta the issue is fixed for me, Thanks!

from siwe.

from siwe.

ethers is still hard coded to 5.5.1 on main:

Unfortunately, ethers v6 is now in beta and I believe it changes the public surface area a bit which might end up in things breaking if someone uses a v6 peer dependency. I don't know if NPM will allow major version changes to peer dependencies automatically with ^5.51 or not, but regardless of whether it does or not I think there needs to be a solution for the transition from ethers v5 to v6, which is likely to happen very slowly across the ecosystem.

Having this library only work with v5 or only work with v6 is going to cause notable pain for some ever-changing portion of the developer base over time.

from siwe.

@safisaleem does this issue still exist? otherwise we will close this.

from siwe.

https://github.com/spruceid/siwe/pull/58/files fixed this in theory, but anyone using the npm registry will still have the issue because #58 doesn't seem to have been published yet

from siwe.

agree with what @joewagner said

from siwe.

ethers is still hard coded to 5.5.1 on main:

siwe/packages/siwe/package.json

Line 30 in 6a9a8a2

"ethers": "5.5.1"

Unfortunately, ethers v6 is now in beta and I believe it changes the public surface area a bit which might end up in things breaking if someone uses a v6 peer dependency. I don't know if NPM will allow major version changes to peer dependencies automatically with ^5.51 or not, but regardless of whether it does or not I think there needs to be a solution for the transition from ethers v5 to v6, which is likely to happen very slowly across the ecosystem.

Having this library only work with v5 or only work with v6 is going to cause notable pain for some ever-changing portion of the developer base over time.

Thanks for the heads up here on a lot of this - we'll work to address!

from siwe.

This issue is fixed in our beta release of siwe 2.0.3. Now the dependency is:

"ethers": "^5.5.1"

I hope that works for you, then we can close this issue.

from siwe.

^ will only do minor and patch updates. It won't do major updates. You can do >5.5.1 would work, but I believe that ethers 6 is not fully API compatible with ethers 5, so I recommend testing before moving forward with this strategy.

from siwe.

^ will only do minor and patch updates. It won't do major updates. You can do >5.5.1 would work, but I believe that ethers 6 is not fully API compatible with ethers 5, so I recommend testing before moving forward with this strategy.

@MicahZoltu Ok, we will close this issue and created a new one for ethers 6 upgrade path.

from siwe.