SqlCall calculates the number of input parameters wrong [DATAJDBC-7] about spring-data-relational HOT 4 CLOSED

Thomas Risberg commented

Does your code call setFunction(true)?

http://static.springsource.org/spring/docs/3.0.x/javadoc-api/org/springframework/jdbc/object/SqlCall.html#setFunction%28boolean%29

That's necessary if you are calling a function.

Also, anything that is part if Spring Framework should go in as a Spring JIRA issue (https://jira.springsource.org/browse/SPR). I'll move this later if necessary.

-Thomas

from spring-data-relational.

Catwalker Liu commented

Yes I did call setFunction(true) after these declareParameter(...)

In code line 132-152 parameterCount is set to -1 for function, but the code also exclude SqlReturnResultSet effectively. (parameterCount++ is inside of instanceof check).
This is double de-count for (function+SqlReturnResultSet) case.

from spring-data-relational.

Thomas Risberg commented

Yes, that is correct - SqlReturnResultSet is used with SQL Server and Sybase that return resultsets from regular stored procedure calls. Didn't think of that initially, and since you are calling a function it's not the right parameter type to use. Depending on the database your parameter would look a bit different. If you are using Oracle try the following:

declareParameter(new SqlOutParameter("rs", oracle.jdbc.OracleTypes.CURSOR, new MyMapper()));

and for Postgres you would use:

declareParameter(new SqlOutParameter("rs", Types.OTHER, new MyMapper()));

Let me know how this works out or if you are using some other database.

-Thomas

from spring-data-relational.

Thomas Risberg commented

I'm closing this issue. If you are still having problems you can open a new Spring Framework issue (https://jira.springsource.org/browse/SPR).

-Thomas

from spring-data-relational.