Add support for searching by Specification and Sort [DATAJPA-48] about spring-data-jpa HOT 6 CLOSED

Stevo Slavić commented

Wish SimpleJpaRepository is more designed for extension. To add workaround until this ticket is resolved, had to duplicate/shadow fields and multiple methods. If only getEntityManager and getQuery methods were protected and not private

from spring-data-jpa.

Dustin Woods commented

I too would like to see the getQuery method be 'protected' instead of 'private' to apply query hints when using specifications. Should this be a separate issue?

from spring-data-jpa.

Oliver Drotbohm commented

I've added the method. What are you exactly meaning with the generated test source directory?

from spring-data-jpa.

Stevo Slavić commented

Some test sources are generated (using com.mysema.maven:maven-apt-plugin). Only default test source directory is src/test/java. For directory with generated test sources to be compiled and added to test scope classpath, build helper plugin is typically used. Without that ordinary test sources which reference generated test source do not compile.

Btw, some javadoc in SimpleJpaRepository has to be updated to reflect changes when JpaSpecificationExecutor was factored out of JpaRepository. I would have done that but formatting surely wouldn't be correct. SpringSource eclipse formatter used to exist

from spring-data-jpa.

Oliver Drotbohm commented

Hi Stevo, have you had a chance to check whether this works for you? The Maven build should just work fine anyway as the APT plugin transparently adds the configured target folder as source folder as well. It builds fine for me on the command line and also does in Eclipse (at least after having done Maven > Update Project configuration in m2eclipse).

from spring-data-jpa.

Stevo Slavić commented

It works for me too, updating project configuration does the trick. By default m2eclipse doesn't run any goals on Maven project import

from spring-data-jpa.