Pagination does not work with eager join fetch of association [DATAJPA-35] about spring-data-jpa HOT 10 CLOSED

Oliver Drotbohm commented

Hi,

we had discussed that in Hades already. There's a countQuery attribute at the @Query annotation that allows you to define the query to be used for counting. I don't really want to go down the route of String manipulation for removing parts of the query. So does that workaround do the trick for you?

Cheers,
Ollie

from spring-data-jpa.

Oliver Drotbohm commented

Here's the link to the discussion:

http://redmine.synyx.org/issues/361

from spring-data-jpa.

Stevo Slavić commented

Yes, that's it, after defining additional countQuery="SELECT count(u) FROM User u" it works. It's not a bug. Couldn't close issue myself. Appologies for making noise

from spring-data-jpa.

Oliver Drotbohm commented

No problem, thanks for your feedback ;)

from spring-data-jpa.

Piotr Jagielski commented

Using countQuery is a valid workaround but I think it should better be handled by the framework. Having to repeat almost the same query twice is cumbersome, especially when the query is large. It may also result in hard to spot bugs when the main query changes and one forgets to update the count query. The referenced discussion mentions a better solution to remove fetch keywords from the count query.

from spring-data-jpa.

Piotr Jagielski commented

On second thought it could probably remove the fetch part altogether instead of just the keyword because fetching shouldn't affect the number of results.

from spring-data-jpa.

Manish Shukla commented

I am using Specifications to form Predicates dynamically. Using countQuery is not possible, is there any other workaround to this issue for Specification ?

from spring-data-jpa.

P. J. Reed commented

I just run into this issue; I'm using .findAll on a repository and passing in a Specification, and it's fairly frustrating that I am apparently unable to specify fetches because it breaks the count query

from spring-data-jpa.

Oliver Drotbohm commented

Please open a dedicated ticket. This one here is not involving specifications at all

from spring-data-jpa.

P. J. Reed commented

Done; see DATAJPA-278

from spring-data-jpa.