Git Product home page Git Product logo

Comments (12)

jhoeller avatar jhoeller commented on March 29, 2024

Which version of ASM is that MainClassFinder impl using? It could switch to
Spring's repackaged one in org.springframework.asm, which as of 4.0 accepts
1.8 bytecode...

Juergen

On Fri, Oct 11, 2013 at 1:59 AM, Phil Webb [email protected] wrote:

./gradlew clean build fails with an IllegalArgumentException
out of ASM's ClassReader, as called from Boot's MainClassFinder on Java
1.8.


Reply to this email directly or view it on GitHubhttps://github.com//issues/88
.

from spring-boot.

dsyer avatar dsyer commented on March 29, 2024

Thanks @jhoeller. The MainClassFinder is in spring-boot-loader-tools where we have explicitly avoided using Spring as a dependency up to now. I suppose we could use the same process as the Spring build to repackage the updates to ASM?

from spring-boot.

jhoeller avatar jhoeller commented on March 29, 2024

We keep Spring Framework 4.0's entire version of ASM in source form in
org.springframework.asm within the spring-core module. You could sync it
from there of course... However, maybe a spring-core dependency isn't so
bad either?

Juergen

On Fri, Oct 11, 2013 at 2:26 PM, Dave Syer [email protected] wrote:

Thanks @jhoeller https://github.com/jhoeller. The MainClassFinder is in
spring-boot-loader-tools where we have explicitly avoided using Spring as a
dependency up to now. I suppose we could use the same process as the Spring
build to repackage the updates to ASM?


Reply to this email directly or view it on GitHubhttps://github.com//issues/88#issuecomment-26133155
.

from spring-boot.

dsyer avatar dsyer commented on March 29, 2024

Yeah spring-core maybe isn't such a bad thing to have on the classpath. Thanks.

from spring-boot.

dsyer avatar dsyer commented on March 29, 2024

@philwebb How do I test this (it all seems to work with jdk1.8 and Maven)?

from spring-boot.

dsyer avatar dsyer commented on March 29, 2024

Looks like this was fixed?

from spring-boot.

philwebb avatar philwebb commented on March 29, 2024

Surprised if that's the case. I thought we would need an ASM upgrade.

from spring-boot.

dsyer avatar dsyer commented on March 29, 2024

Don't we use the same ASM as Spring (from spring-core)?

from spring-boot.

dsyer avatar dsyer commented on March 29, 2024

Looks like @wilkinsona didn't get round to that yet...

from spring-boot.

wilkinsona avatar wilkinsona commented on March 29, 2024

I did. 629a77c updated MainClassFinder to use Spring's ASM.

from spring-boot.

dsyer avatar dsyer commented on March 29, 2024

I thought so, but when I looked at the cli dependencies I saw an asm.jar so I assumed not. Maybe it's still creeping into the cli jar (but not being used)?

from spring-boot.

dsyer avatar dsyer commented on March 29, 2024

It's a groovy dependency, so even though we are now using our own Java 8 compatible asm in the loader-tools, the cli will still pull in asm through groovy.

from spring-boot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.