Provide exit code for job executed as a main method [BATCH-24] about spring-batch HOT 6 CLOSED

Dave Syer commented

ExitStatus from job execution could be correlated with BatchStatus as a sensible default. E.g. COMPLETED=0, FAILED=1, ... Currently it is just 0 (success), 1 (fail). The ExitStatus is only used for the exit code at the moment as well - there is room in the DDL for a message - so the whole exit status could be included in the database.

from spring-batch.

Stijn Maller commented

In the scope of our project we have implemented a few classes that do exactly what is described in this issue. I uploaded them as requested by Lucas Ward. We do depend on a few features of Java 5 which might be a problem for including it in spring-batch? (shouldn't be too hard to change that part of the code if needed)

from spring-batch.

Lucas Ward commented

I committed code that addresses this issue, based upon some of the code submitted by Stijn, and earlier code put in to fix BATCH-40. However, there still needs to be some polish applied (clean up java docs, etc), and I can't figure out a decent way to test the BatchCommandLineLauncher, since it makes a call to System.exit(). I'll finish it up tomorrow and mark as fixed.

from spring-batch.

Stijn Maller commented

I just uploaded the file spring-batch-execution-src-folder In which 2 things were changed:

1. Tests were added to execute the BatchCommandLineLauncher in a new JVM
2. The JvmExitCodeMapper now maps a more generic code for Configuration errors. (In adding this I moved a few constants around to more logical places)

from spring-batch.

Lucas Ward commented

BatchCommandLineLauncher now has unit tests and since it is correctly returning exit codes, I'm closing this issue and marking as fixed. I looked at the approach of kicking off an additional JVM, but I have some concerns about kicking off a new JVM within a unit test. If the current unit testing strategy is felt to be insufficient, a new issue can be opened for M3.

from spring-batch.

Dave Syer commented

I changed the unit test to use the SystemExiter strategy, so we don't need a separate JVM.

from spring-batch.