Git Product home page Git Product logo

Comments (2)

artembilan avatar artembilan commented on April 28, 2024

The RabbitListenerErrorHandler contract does not match with the batch:

Object handleError(Message amqpMessage, @Nullable org.springframework.messaging.Message<?> message,
			ListenerExecutionFailedException exception) throws Exception; 

in comparison with:

void onMessageBatch(List<Message> messages, Channel channel);

Since we have no knowledge with exactly message has failed in the batch when we call:

invokeHandlerAndProcessResult(null, channel, converted);

(see how an AMQP Message is null)
We leave the error handling here up to a generic ErrorHandler on the listener container level.

WDYT?

from spring-amqp.

jyxzwd avatar jyxzwd commented on April 28, 2024

The RabbitListenerErrorHandler contract does not match with the batch:

Object handleError(Message amqpMessage, @Nullable org.springframework.messaging.Message<?> message,
			ListenerExecutionFailedException exception) throws Exception; 

in comparison with:

void onMessageBatch(List<Message> messages, Channel channel);

Since we have no knowledge with exactly message has failed in the batch when we call:

invokeHandlerAndProcessResult(null, channel, converted);

(see how an AMQP Message is null) We leave the error handling here up to a generic ErrorHandler on the listener container level.

WDYT?

I got it. Because we have no knowledge with exactly message has failed during porcessing, except in our custom listener code.
I think this is the reason. And thank u for explaning to me.

from spring-amqp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.