Doubt for close() method of TraceScope class about spring-cloud-sleuth HOT 4 CLOSED

Why do you think it's a problem?

from spring-cloud-sleuth.

In TraceCallable and TraceRunnable, first span is started and we get TraceScope reference and run the delegated Thread(Runnable or Callable) and when it is done. We call close() of that particular scope, which does as mentioned in above question.
My concern is related to Executors. If one executor is shared to do some process and multiple requests are coming which is catered by some service using executors(It is just a use case). Then in worker threads of executors, the above code is creating problem and lead to Htrace error message when space is started. This is the reason I asking for this way. Isn't it if Worker thread is done its processing then it should clear its ThreadLocal context as well.

I will write some sample app with code which is able to reproduce this problem and with possible solution.

from spring-cloud-sleuth.

I'm not sure I see the problem yet, but a sample project will certainly help. BTW I'm in the middle of a big refactor of all the core APIs so the names and locations of things might change soon.

from spring-cloud-sleuth.

I have created the sampleapp
https://github.com/gauravrmazra/spring-cloud-sleuth-executor-sampleapp

If multiple request are send from UI, it throws weird Htrace error (runtime exception)

The solution is simple. Just remove the current span from ThreadLocal context of the worker thread within TraceCallable and TraceRunnable

from spring-cloud-sleuth.