Comments (1)
I will explain the whole problem. I was evaluating the Spring cloud sleuth for tracing. There was no direct support for executors but there were two classes TraceCallable and TraceRunnable in Sleuth which supports tracing. I wrote one ExecutorService to wrap Runnable and Callable to their respective Traceable implementations. I created one instance of that ExecutorService(FixedThreadPool with 3 threads as its size. The size here doesn't matter).
The app I created is Spring Boot app which accepts request from UI(browser), sends it to Service layer to cater that request(Service layer uses Executor). I was sending multiple requests to test the feasibility of support for Executors. Then I found the weird Htrace error. Earlier I thought the issue might be because in worker Thread, span is not removed from their thread local variable. This is still true. But when I wrote unit test case to support my hypothesis, I found everything is working fine. The code for unit test case is :
@Test
public void test_whenTraceContextOfWorkerThreadIsNotClosed_thenException() {
final AtomicInteger counter = new AtomicInteger(0);
final CountDownLatch latch = new CountDownLatch(TOTAL_THREADS);
TraceScope scope = this.trace.startSpan("PARENT");
for (int i = 0; i < TOTAL_THREADS; i++) {
traceableExecutorService.execute(new MyRunnable(counter, latch));
}
try {
latch.await();
} catch (InterruptedException e) {
e.printStackTrace();
}
scope.close();
verify(this.publisher, times(NUM_SPANS)).publishEvent(isA(SpanAcquiredEvent.class));
verify(publisher, times(NUM_SPANS)).publishEvent(isA(SpanReleasedEvent.class));
ArgumentCaptor<ApplicationEvent> captor = ArgumentCaptor
.forClass(ApplicationEvent.class);
verify(publisher, atLeast(NUM_SPANS)).publishEvent(captor.capture());
List<Span> spans = new ArrayList<>();
for (ApplicationEvent event : captor.getAllValues()) {
if (event instanceof SpanReleasedEvent) {
spans.add(((SpanReleasedEvent) event).getSpan());
}
}
assertThat("spans was wrong size", spans.size(), is(NUM_SPANS));
}
After giving it a think, I found that in close() of TraceScope class, last line is TraceContextHolder.setCurrentSpan(this.savedSpan);
When I printed on console this saved span, it was the parent span when these TraceCallable or TraceRunnable were created.
Now the scenerio is, In web-based application and when we are sharing that executorService and when multiple requests are coming in TraceFilter starts or continue the span. For two different requests, the parent span will be different and if in the executorService same thread tries to execute task, it will throws weird Htrace error. I hope I explained the problem in detail.
from spring-cloud-sleuth.
Related Issues (20)
- I want to propagate TraceId to all places where parallelStream() and CustomForkJoinPool is used. HOT 3
- CVE-2023-33201 - bcprov-jdk15on HOT 5
- Missing traceId when using spring-cloud-starter-stream-rabbit consumer listeners. HOT 5
- Tracing support for Reactive Kafka (Using KafkaSender and KafkaReceiver) HOT 2
- Spring boot 2.7.10/Sleuth/Micrometer/Prometheus/Brave/Zipkin HOT 1
- java.lang.IllegalStateException: Missing: traceId with AWS propagation type HOT 5
- Jetty BadMessageException request headers too large HOT 3
- LazyTraceThreadPoolTaskExecutor.getQueueSize() does not call a delegate and always returns 0 HOT 3
- ReactorSleuth.tracedMono does not work with parallel processing HOT 1
- TraceReactorAutoConfiguration.HooksRefresher improper queue decoration
- Need documentation for collecting data using baggage. HOT 1
- Sleuth giving different traceIds for each RxJava's Single execution HOT 3
- TraceIds feature for a Request tarvelling across, doesn't seem working. TraceIds are different across a travelling request HOT 3
- After @Async is included in rpc, traceId loss and confusion occur under a large number of requests. HOT 4
- Autoconfiguration does not work in spring-boot 3.x HOT 1
- docs: Getting Started Image Not found
- DataSource Proxy + Spring Could Sleuth not working HOT 4
- spring.zipkin.discoveryClientEnabled ignored when the traced app is webflux HOT 1
- sleuth-3.1.9+datasource-proxy-1.10+flowable-6.8.0 Unable to start the springboot project properly HOT 1
- Why doesn't Sleuth enable Scope when create Span for Kafka Streams by default? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-cloud-sleuth.