On the other hand, there is probably no better value to be had. We know the service name (which is all you really need in Cloud Foundry), and the IP/port information is really not adding anything. If we could make it a String instead of an Address we could maybe do something more informative (the space id or something), but Zipkin mandates the IP address, so there's not much we can do if we want to have the option of using Zipkin.

from spring-cloud-sleuth.

you could put 0 for the ip and port when there is no valid value.

I think serviceName will eventually migrate to a tag, like below. Ex
sleuth could choose to use tags instead of endpoints now, and just put
0 if there's no ipv4 or port.

https://github.com/opentracing/opentracing-python/blob/master/opentracing/ext/tags.py

PEER_SERVICE records the service name of the peer

PEER_SERVICE = 'peer.service'

PEER_HOSTNAME records the host name of the peer

PEER_HOSTNAME = 'peer.hostname'

PEER_HOST_IPV4 records IP v4 host address of the peer

PEER_HOST_IPV4 = 'peer.ipv4'

PEER_HOST_IPV6 records IP v6 host address of the peer

PEER_HOST_IPV6 = 'peer.ipv6'

PEER_PORT records port number of the peer

PEER_PORT = 'peer.port'

from spring-cloud-sleuth.

from spring-cloud-sleuth.

Update on this issue, starting with Zipkin 1.4 endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address.

from spring-cloud-sleuth.

This will be solved to some extent by #369 . We'll be setting a tag with client / server instanceId property

from spring-cloud-sleuth.

Fixed by #369

from spring-cloud-sleuth.