Comments (10)
spencergibb
commented on May 24, 2024
from spring-cloud-sleuth.
codefromthecrypt
commented on May 24, 2024
neat! @jpinner thoughts on this?
from spring-cloud-sleuth.
b
commented on May 24, 2024
i'm in love.
from spring-cloud-sleuth.
spencergibb
commented on May 24, 2024
@b now that the infrastructure is in place, adding those http annotations was fairly straightforward.
from spring-cloud-sleuth.
codefromthecrypt
commented on May 24, 2024
PS question: is this illustrative? Ex we expect to sink all
dimensions/annotations in the namespace? Or would usage more often be
sparse? Feel free to punt this.
Regardless, I like seeing how it looks.
from spring-cloud-sleuth.
b
commented on May 24, 2024
i'd like to see everything namespaced in this way
from spring-cloud-sleuth.
jpinner
commented on May 24, 2024
only comment would be to take a look at how the request / response first
lines are folded into the header namespace in HTTP/2 -- might make it more
forward-compatible do have things like:
/http/request/method
/http/request/scheme
/http/request/authority
/http/request/path
/http/request/headers/host
from spring-cloud-sleuth.
b
commented on May 24, 2024
i think i noted this in the doc: http/2 is sufficiently different from 1.x that i believe it should be in its own namespace (/http2)
from spring-cloud-sleuth.
spencergibb
commented on May 24, 2024
@adriancole should we keep this issue open or create new issues for different sections as the need arises?
from spring-cloud-sleuth.
codefromthecrypt
commented on May 24, 2024
This would be implemented per component, so if we left this issue open, it
might be open for years. I'd close it as I think the value is understood,
and progress can be logged per component (and likely many PRs per component
till we get it right!)
from spring-cloud-sleuth.
Related Issues (20)
- I want to propagate TraceId to all places where parallelStream() and CustomForkJoinPool is used. HOT 3
- CVE-2023-33201 - bcprov-jdk15on HOT 5
- Missing traceId when using spring-cloud-starter-stream-rabbit consumer listeners. HOT 5
- Tracing support for Reactive Kafka (Using KafkaSender and KafkaReceiver) HOT 2
- Spring boot 2.7.10/Sleuth/Micrometer/Prometheus/Brave/Zipkin HOT 1
- java.lang.IllegalStateException: Missing: traceId with AWS propagation type HOT 5
- Jetty BadMessageException request headers too large HOT 3
- LazyTraceThreadPoolTaskExecutor.getQueueSize() does not call a delegate and always returns 0 HOT 3
- ReactorSleuth.tracedMono does not work with parallel processing HOT 1
- TraceReactorAutoConfiguration.HooksRefresher improper queue decoration
- Need documentation for collecting data using baggage. HOT 1
- Sleuth giving different traceIds for each RxJava's Single execution HOT 3
- TraceIds feature for a Request tarvelling across, doesn't seem working. TraceIds are different across a travelling request HOT 3
- After @Async is included in rpc, traceId loss and confusion occur under a large number of requests. HOT 4
- Autoconfiguration does not work in spring-boot 3.x HOT 1
- docs: Getting Started Image Not found
- DataSource Proxy + Spring Could Sleuth not working HOT 4
- spring.zipkin.discoveryClientEnabled ignored when the traced app is webflux HOT 1
- sleuth-3.1.9+datasource-proxy-1.10+flowable-6.8.0 Unable to start the springboot project properly HOT 1
- Why doesn't Sleuth enable Scope when create Span for Kafka Streams by default? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-cloud-sleuth.