Comments (5)
This kind of "default to local" mechanism would ideally check that none of the other cloud connectors (Cloud Foundry, Heroku, or others that might be created later) had returned true
from isInMatchingCloud()
, as opposed to just checking that the app is not running in CF.
You are correct than the cloud connector modules do not know about the Spring app context. In fact, by design, only the spring-cloud-spring-service-connector
module has any dependency on or knowledge of Spring. So this kind of detection, defaulting, and wiring to Spring Boot should happen in a layer above the cloud connectors.
Maybe what you are suggesting could be triggered by an @Enable
annotation provided in the spring-service-connector
, which would allow the local config to be specified as a default. Support code could kick in and populate the properties used by the local cloud connector from mechanisms known to Spring Boot. Or this could be another condition supported by spring-boot-autoconfigure.
from spring-cloud-connectors.
It's not entirely clear to me what it is you're trying to do. How are you wanting to configure services through Spring Boot--using the application.properties
and listing out the URI components? Why do you want to have multiple different configuration paths instead of just putting those complete URIs in a file?
from spring-cloud-connectors.
@scottfrederick yes, a more general isInMatchingCloud()
would be ideal. An empty getServicesData()
may still work as boot has default ways to configure things like mongo.
@chrylis what I am trying to avoid is having the normal boot application.properties
and the local connector config file.
from spring-cloud-connectors.
@spencergibb I would have liked to have the spring.cloud
properties made available via the main environment abstraction, but the constraint that core
doesn't have any Spring dependencies prevented that. Unfortunately, your proposed local connector has the downside of having to know about every possible deployment option and exclude it.
from spring-cloud-connectors.
@chrylis my NotCFConfigConnector
was just an example of what I did so my local running boot app didn't have to have a local connector. isInMatchingCloud()
could be something like spring.cloud.boot.connector=true
.
Maybe it's not a spring boot connector, just a no-op one like I've written (spring.cloud.noop.connector=true
) and let boot configure things as it does without spring cloud during local development.
from spring-cloud-connectors.
Related Issues (20)
- Critical CVE related to com.fasterxml.jackson.core:jackson-databind
- Redis Service Uris in Cloud Foundry do not contain user info, thus UriBasedServiceInfo throws exception HOT 1
- Support for reactive mongodb connection HOT 4
- Make it clear that Spring Cloud Connectors is in maintenance mode HOT 1
- CVE-2019-12814 related to com.fasterxml.jackson.core:jackson-databind HOT 5
- Redis connector has a race condition with Spring Boot 2.x
- PropertyMaskingContextInitializer prevents configuration of "keys-to-sanitize" HOT 1
- Maintenence mode? HOT 1
- Update spring-cloud-cloudfoundry-connector Jackson dependencies from 2.9.1 to latest version 2.10.0 HOT 1
- New release for jacksonVersion = "2.10.0" ? HOT 4
- maxWaitTime of PoolConfig is not used HOT 4
- spring-cloud-connector fails to detect MongoDB service broker (DNS Seedlist Connection Format) in PCF HOT 1
- MailSenderCreator Create Method accepts the ServiceConnectorConfig object, but does not set the config property to JavaMailSender HOT 1
- spring-cloud-cloudfoundry-connector 2.0.7.RELEASE can't be used in a modular Java 11 project HOT 2
- Mongo Connector doesn't work with Spring Boot 2.4.1? HOT 7
- CVE-2020-25649 - related to com.fasterxml.jackson.core:jackson-databind inspring-cloud-cloudfoundry-connector-2.0.7.RELEASE.jar HOT 7
- Vulnerable version of Jackson-Databind with Spring-Cloud-cloudfoundry-connector HOT 1
- HiKari datasource in spring cloud (CF) failed to set PG related connection properties HOT 2
- java.lang.IllegalAccessError: failed to access class com.mongodb.client.internal.MongoClientDelegate from class com.mongodb.Mongo HOT 2
- Redis connection pool config not working HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-cloud-connectors.