Issue with Sidekiq on Spree 3.0 with spree_shared about spree_shared HOT 5 CLOSED

It may or may not help to try removing the spring gem we've been having all sorts of code reloading issues from it, and removing spring generally solves the problems although not sure if this ones related at all.

from spree_shared.

@JDutil No, this one isn't related to spring. It is because of https://github.com/spree-contrib/spree_shared/blob/master/lib/spree_shared/spree_preferences_extensions.rb
But I don't really understand why not 97008d3
Do you have any insights?

from spree_shared.

On the one hand such eager loading can help to override behavior of some initializers (who knows which ones?). But on the second hand, it looks like nonsense, b/c we set Apartment::Tenant.current_tenant from request subdomain, so in all initializers it will be just 'public'.

from spree_shared.

I'm not really sure this extension was written by someone else, and I've just done some upgrades to it as necessary. I think your changes look fine, but would be good to test them out. It looks like the initial code was done back in 2012:
e1c5401

There probably just wasn't as clear of best practices when writing extensions then.

from spree_shared.

I've figured out the reason of this strange preloading. That was needed for specs, but the same result can be achieved with help of regular eager loading: https://github.com/spree-contrib/spree_shared/blob/3-0-stable/lib/spree_shared/engine.rb#L10..L12

from spree_shared.