Support for Spree 3.2? about spree_braintree_vzero HOT 11 CLOSED

In case someone still has this problem, I managed to fix it by updating Spree. Yeah, updating, apparently I was in 3.2.0.rc2.

I realized that I wasn't able to override some code present on the current stable branch. That was what made me discover the issue. In the end I just did bundle update and poof, problem fixed, I'm now in 3.2.0.

If someone is curious, the problem was in the previous PaymentMethodsController class, it didn't have the current preferences_params method. If you are in another spree version and have the problem, take a look at that.

from spree_braintree_vzero.

@cstrutton you're using the proper master branch which supports Spree 3.1, 3.2 and 3.3 (in future). We'll check it out on Monday, thanks for reporting!

from spree_braintree_vzero.

FYI I have done some investigating. I don't know why but I can not find any settings (merchant id, public or private key) saved in the database. I can give access to my cloud 9 test bed if you need it.

from spree_braintree_vzero.

I did some debugging and I think that I managed to trace the problem. It seems that when updating a PaymentMethod, the params are not permitted. See here. I tried to permit them and this resolved the problem. However, I'm not too sure about the "fix", so I don't know if I should make a merge request with it.

from spree_braintree_vzero.

Hi @mzdravkov please submit a PR for https://github.com/spree/spree

from spree_braintree_vzero.

@mzdravkov how did you 'fix'?

from spree_braintree_vzero.

Ok, I really should have made a PR at the time, because now I don't remember exactly what I did two weeks ago... I tried to run version 3.1 of spree, and this is what I'm currently running, but I investigated the code of the different versions of spree that I have on my machine and I found what the change in payment_methods_controller.rb in version 3.2 of spree is:

I have changed this line to:
update_params = payment_method_params[ActiveModel::Naming.param_key(@payment_method)] || {}

(use payment_method_params instead of params)

You can try this. I'm sorry that I'm not able to help you better.

from spree_braintree_vzero.

@damianlegawiec this is still pending? We have this issue with Rails 4.2.7 and Spree 3.0.0.rc4. How can we solve it?

from spree_braintree_vzero.

Update: was unable to fix this or downgrade, and lost a small client

from spree_braintree_vzero.

And this is why you never use unstable code children! 🦄

from spree_braintree_vzero.

I am still facing similar problem on fresh install of Spree. Its happening when I go from delivery to checkout, while BraintreeVzeroPaypalExpress payment method is enabled in store

NoMethodError in Spree::Checkout#edit

Showing /home/username/workspace/spree_sandbox/spree_braintree_vzero/app/views/spree/checkout/payment/braintree_vzero/_three_d_secure.html.erb where line #7 raised:

undefined method `to_sym' for {:values=>[:sandbox, :production]}:Hash

ruby 2.6.5
rails 6.0.2.2
spree 4.1.2

BraintreeVzeroHostedFields and BraintreeVzeroDropinUi are also affected, since they also have hash as a value for server, instead of string, as other gateways

from spree_braintree_vzero.