Paypal express – payments not captured about spree_braintree_vzero HOT 5 CLOSED

@Mafi88 Yes. Thank you very much!

from spree_braintree_vzero.

@vmatekole it looks like your payment was not processed (maybe https://github.com/spree-contrib/spree_braintree_vzero/blob/master/app/models/spree/order_decorator.rb#L2 is not firing)?

Please try order.process_payments! in console and check if payment got processed (both Spree and Braintree)

from spree_braintree_vzero.

@Mafi88 Thank you so much for your support — you were correct but I don't understand the root cause, perhaps you can explain....

I have an existing order decorator, it appears this somehow was preventing the after_transition ("complete") state in the above decorator from firing, here is an excerpt:

Spree::Order.class_eval do
  # alias_method :can_ship?, :ship
  # Vend Inventory reconcile step
  insert_checkout_step :reconciled, :after => :complete
  Spree::Order.state_machine.before_transition :to => :complete, :do => :paypal
  Spree::Order.state_machine.after_transition :to => :complete, :do => :update_vend_inventory_status
  Spree::Order.state_machine.after_transition :to => :reconciled, :do => :log_order

I had to include my own method and duplicate the following code and the after_transition('complete') :

def paypal
    process_paypal_express_payments
end

def process_paypal_express_payments
    return unless paid_with_paypal_express?
    if payments.valid.empty?
      order.errors.add(:base, Spree.t(:no_payment_found))
      false
    else
      payments.valid.last.update(amount: total)
      process_payments!
    end
  end

from spree_braintree_vzero.

@vmatekole it happens to me when I mess with checkout flow (insert/remove checkout steps) Lately I had the same problem with tax_cloud before_transition.

I think that you only need to duplicate the transition method from gem, so:

state_machine.before_transition to: :complete, do: :process_paypal_express_payments

without overriding the actual process_paypal_express_payments method. Only this one line.

Also, I recommend usage of before_transition here, because it's the default checkout flow.
Right now, if it fails, customer will probably get order_complete email, not sure if inventory won't get processed too.

from spree_braintree_vzero.

@vmatekole did it help?

from spree_braintree_vzero.