ShippingError rescue is holding back other results about spree_active_shipping HOT 9 CLOSED

I question if there is any value to raising an error here. Perhaps we should just return nil?

cc @cmar @LBRapid

from spree_active_shipping.

@rterbush I think that would make sense but only if we handle the exception of really no methods available through any provider in @order.rate_hash in the order model here https://github.com/spree/spree/blob/1-3-stable/core/app/models/spree/order.rb#L425

else we would return either an array with nil values or an empty array by the next unless logic

does this make sense?

from spree_active_shipping.

Agreed. We have recently encountered this in 2.0 and are dealing with it at the moment with the following:

https://gist.github.com/rterbush/5853985

Still waiting on the seniors to weigh in on the general issue.

from spree_active_shipping.

@mrpollo I think that checking for available methods in the #rate_hash method of the Order model makes a lot of sense.

@rterbush I'm not super familiar with this extension these days but I think I understand the issue at hand and believe you are both on the right track. Let me know if you need anymore assistance.

from spree_active_shipping.

@rterbush I'm submitting fixes for Spree 1-3, do you have it fixed on Spree 2 as well? maybe we can both send the PR's

from spree_active_shipping.

I will follow up with PRs on 2-0-stable and master.

from spree_active_shipping.

Feedback wanted, need to raise an error inside @order.rate_hash but Spree::ShippingError i inside spree_active_shipping what should I be raising instead?

spree/spree#3268

from spree_active_shipping.

never-mind on the feedback

from spree_active_shipping.

oh wow nice, thanks!

from spree_active_shipping.