1.2 breaks travis for our repo about python-rtmidi HOT 8 CLOSED

It seems that your version of the jack library does not have jack_port_rename. This was added to jack1 in 2016 and to jack2 in summer 2017 at the latest. Let me know, if for some reason you can't update to a more current version of jack and I'll think about a way to make setting the JACK_HAS_PORT_RENAME directive for the compiler configurable.

from python-rtmidi.

We're just running sudo apt-get libjack-dev (https://github.com/tensorflow/magenta/blob/master/.travis.yml). Should we be installing it some other way to get a newer version?

from python-rtmidi.

The Travis build environment is based on Ubuntu 14.04 (Trusty) or 16.04 (Xenial) apparently. Unfortunately, even in the latter, the version of libjack-dev (jack1) is only 0.124.1, which is ancient, and libjack-jackd2-dev (jack2) is version 1.9.10, which is also too old (1.9.11+ should work). :-(

This is unfortunate, since these distributions are probably still widely used and I don't know a simple way to update the jack version on these distros. I'll think about a way to detect the jack version in the python-rtmidi's setup.py and set JACK_HAS_PORT_RENAME accordingly.

Until then, I can only suggest to either a) install jack from source (which isn't too complicated) or b) disable jack support in python-rtmidi (by installing it separately from source and passing --no-jack to python setup.py install.)

from python-rtmidi.

Tentative fix in e4a4f33.

I still want to set up a Travis environment for Linux builds too before I do a bugfix release.

from python-rtmidi.

Thanks!

from python-rtmidi.

I just released version 1.2.1, which contains the above mentioned fix.

With this release I also enhanced python-rtmidi's own Travis setup to also test the build under Linux (Ubuntu Xenial) for Python 2.7 and 3.4 - 3.5.

Interestingly, when you use the dist: xenial build environment on Travis and when you install libjack-jack2-dev, the deb that gets installed has the version 1.9.10+20150825git1ed50c92~dfsg-1ubuntu1 but JACK identifies itself as version 1.9.11 via pkg-config and it compiles ok with JACK_HAS_PORT_RENAME set. If you install libjack-dev instead, you get JACK 1 version 0.124.x, which triggered the error you were encountering. But with the above mentioned fix, python-rtmidi can be built with either one.

from python-rtmidi.

from python-rtmidi.

It's not strictly necessary, since the new set_port_name method will now work with jack library versions, which do not have the jack_port_rename function as well. But I know from personal conversations with the jack maintainer (falkTX) that jack1 will not be developed any further any more, so jack2 is the way to go, unless you're using features that are still only available in jack1.

Also, the Travis builds for Linux I have set up now are using libjack-jackd2-dev, so this build variant is the one tested.

from python-rtmidi.