Git Product home page Git Product logo

Comments (2)

gmucha avatar gmucha commented on May 27, 2024

OK, so trying to look what's happening - on the client, when deserializing the response from cluster looks truncated - see
https://gist.github.com/gmucha/68ac9f6dbe6baf7d3f31

Ok - so the problem seems to be caused by the fact that only a part of the file is being read - after the 1st read available() on GzipInputStream returns 1 -so there's more to be read. More proper version would be something like this patch (basic version,

IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- rpc/nativerpc/src/main/java/com/spotify/heroic/rpc/nativerpc/NativeUtils.java   (revision a5fb75376677b7cfcbd918557b78736a3e1af782)
+++ rpc/nativerpc/src/main/java/com/spotify/heroic/rpc/nativerpc/NativeUtils.java   (revision )
@@ -46,9 +46,16 @@
         final byte[] bytes = new byte[bodySize];

         try (final GZIPInputStream in = new GZIPInputStream(new ByteArrayInputStream(body))) {
-            in.read(bytes);
+            byte[] buf = new byte[1024];
+            int idx = 0;
+            while (in.available() > 0) {
+                int read = in.read(buf);
+                if (read > 0) {
+                    System.arraycopy(buf, 0, bytes, idx, read);
+                    idx += read;
-        }
+                }
-
+            }
+        }
         return bytes;
     }

from heroic.

udoprog avatar udoprog commented on May 27, 2024

This issue should now be fixed, thanks for the report!

from heroic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.