Comments (2)
OK, so trying to look what's happening - on the client, when deserializing the response from cluster looks truncated - see
https://gist.github.com/gmucha/68ac9f6dbe6baf7d3f31
Ok - so the problem seems to be caused by the fact that only a part of the file is being read - after the 1st read available() on GzipInputStream
returns 1 -so there's more to be read. More proper version would be something like this patch (basic version,
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- rpc/nativerpc/src/main/java/com/spotify/heroic/rpc/nativerpc/NativeUtils.java (revision a5fb75376677b7cfcbd918557b78736a3e1af782)
+++ rpc/nativerpc/src/main/java/com/spotify/heroic/rpc/nativerpc/NativeUtils.java (revision )
@@ -46,9 +46,16 @@
final byte[] bytes = new byte[bodySize];
try (final GZIPInputStream in = new GZIPInputStream(new ByteArrayInputStream(body))) {
- in.read(bytes);
+ byte[] buf = new byte[1024];
+ int idx = 0;
+ while (in.available() > 0) {
+ int read = in.read(buf);
+ if (read > 0) {
+ System.arraycopy(buf, 0, bytes, idx, read);
+ idx += read;
- }
+ }
-
+ }
+ }
return bytes;
}
from heroic.
This issue should now be fixed, thanks for the report!
from heroic.
Related Issues (20)
- Configurable Option to Index Resource Identifiers in Elasticsearch
- Heroic Bigtable Consumer does not handle failures as expected HOT 10
- ## Codestyle: enforce consistent statement-spacing and indentation (See issue #720)
- Implement new Bigtable timeout settings
- Rework all timer-based Tests
- upgrade bigtable-client-core library from 1.12.1 to 1.18.1 (latest) to eliminate retries bug HOT 1
- Replace bigtable-client-core lib with com.google.cloud:google-cloud-bigtable
- Bigtable server-side and client-side & Heroic-side behaviour analysis HOT 1
- RotatingIndexMapping interval is not read from config
- Dynamically determine metadata read indices based upon query range
- Analyse Heroic and user's perspective when hitting a timeout. Then implement necessary changes. HOT 2
- Distribution Documentation
- Mandatory client ID filter does not return informational message upon query rejection
- Investigate & resolve nondeterministic build errors HOT 1
- add x-client-id to markdown documentation examples for /query/[metrics|batch]
- Instrument Bigtable timeouts (add metrics and log messages)
- Fix "...Span <span name> is GC'ed without being ended." issue (caused by a BT timeout) HOT 1
- Investigate potentially serious performance implications of seemingly unnecessary thread-per-log message logging implementation
- integrationTests requires "hidden" quay.io/testcontainers/ryuk docker image HOT 1
- Downloads often cancel (stall) and no auto-resuming happens. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heroic.