Git Product home page Git Product logo

Comments (2)

pjthepooh avatar pjthepooh commented on June 24, 2024

After some digging, i found that mutating webhook is used to set default values in flinkcluster_default.go. When mutating webhook is disabled, job submitter will be run in Blocking mode vs Detached mode because of this logic along with other potential unexpected behaviors.

Another note is the CRD doc is not updated , i.e. not reflecting the actual available fields defined in the CRD yaml, e.g. job.mode, JM.replicas etc.

Looks like setting default values is basically all mutating webhook does and we can safely disable it if we already pre-fill those fields?

from flink-on-k8s-operator.

regadas avatar regadas commented on June 24, 2024

Hi @pjthepooh yup pretty much. The mutation webhook only adds defaults. I'll close this now ... feel free to open it if you want to keep discussing it.

from flink-on-k8s-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.