Git Product home page Git Product logo

Comments (8)

rohansingh avatar rohansingh commented on May 18, 2024

We actually don't have any way to provide credentials, so pushing to the public registry isn't going to work. We'd need to add that to docker-client. It's not on our backlog right now, but happy to accept a pull request.

from docker-maven-plugin.

mattijsf avatar mattijsf commented on May 18, 2024

Ah I see! I thought it used the underlying docker credentials. So if the underlying docker is logged-in it would use those credentials inherently when pushing images.

I'll see if I can contribute something here.

from docker-maven-plugin.

JakubKahovec avatar JakubKahovec commented on May 18, 2024

I'm having the issue, trying to push to a private registry on the docker hup.
Any update on this ?

from docker-maven-plugin.

davidxia avatar davidxia commented on May 18, 2024

@mattijsf @JakubKahovec docker-client supports pushing with auth credentials here https://github.com/spotify/docker-client/blob/master/src/main/java/com/spotify/docker/client/DefaultDockerClient.java#L719. We need to make docker-maven-plugin set the creds.

from docker-maven-plugin.

JakubKahovec avatar JakubKahovec commented on May 18, 2024

It'd be great if it's possible to fetch the credentials (the password especially) from env or sys variables so they are not exposed in the pom file.

from docker-maven-plugin.

davidxia avatar davidxia commented on May 18, 2024

Creds dont have to be in the versioned pom. I see many people putting
passwords in their maven settings.xml file which isn't versioned. These can
also be overridden with -D options

On Saturday, January 31, 2015, Jakub Kahovec [email protected]
wrote:

It'd be great if it's possible to fetch the credentials (the password
especially) from env or sys variables so they are not exposed in the pom
file.


Reply to this email directly or view it on GitHub
#35 (comment)
.

David Xia
Software Engineer
[email protected]

from docker-maven-plugin.

davidxia avatar davidxia commented on May 18, 2024

@mattijsf Do you still need help or can I close this?

from docker-maven-plugin.

JakubKahovec avatar JakubKahovec commented on May 18, 2024

Thanks, you can close it.

from docker-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.