bug with "get_nns_by_item"? about annoy HOT 14 CLOSED

Did you try the latest code? I think I actually fixed this yesterday

ae74624

from annoy.

The underlying python C extension doesn't handle kw arguments so well but I solved it by a dumb wrapper on the Python side

from annoy.

ok, I'll test it again tomorrow. Thank you.

from annoy.

Yes, I confirm that I use the latest version of Annoy (1.5.2), and the described bug still occurs. I'm on Python 3.4.3.

from annoy.

When I meant latest version I meant bleeding edge github master.

I updated master but didn't push it to pypi. I can bump the version and
push. I keep forgetting to do that so in glad you reminded me :)

On Friday, November 13, 2015, Horace89 [email protected] wrote:

Yes, I confirm that I use the latest version of Annoy (1.5.2), and the
described bug still occurs. I'm on Python 3.4.3.

—
Reply to this email directly or view it on GitHub
#114 (comment).

from annoy.

I bumped the version to 1.6.0 and pushed it to PyPI

from annoy.

@erikbern
I'm having trouble installing annoy through pip after this update:

Installing collected packages: annoy
  Found existing installation: annoy 1.5.2
    Uninstalling annoy:
      Successfully uninstalled annoy
  Running setup.py install for annoy
    building 'annoy.annoylib' extension
    x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include/python2.7 -c src/annoymodule.cc -o build/temp.linux-x86_64-2.7/src/annoymodule.o -O3 -march=native -ffast-math
    cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
    src/annoymodule.cc:16:24: fatal error: kissrandom.h: No such file or directory
     #include "kissrandom.h"
                            ^
    compilation terminated.
    error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

Clonning and running python setup.py install works fine.

from annoy.

let me take a look at it

from annoy.

I had forgotten to include src/kissrandom.h in setup.py.

I added it and pushed 1.6.1.

Sorry about the inconvenience

from annoy.

hm still not working – not sure what's going on. let me try again

from annoy.

try again – had to bump to 1.6.2 :(

from annoy.

Works great now. Thanks for the quick fix!

from annoy.

That's what I call rapid development! :)

Btw PyPI treats rc1, rc2 tags as proper releases, which pip will ignore when users ask to install (a good option for release checking).

from annoy.

It's working great now! Thanks!

from annoy.