Git Product home page Git Product logo

Comments (8)

Zidane avatar Zidane commented on June 1, 2024

@gabizou

We discussed this at length last night. I will say that when @bloodmc first got the world changes working in Sponge and I removed the plugin creating the world, it surprised me when they still loaded. Maybe this stems from the fact that a world never existed in Spout unless a plugin provided it.

The beauty of this is it isn't too...difficult to support this as we can simply track if a world is set to load and then only load worlds that fit this criteria. Question is, should this be the expected behavior or leave as-is?

from sponge.

gabizou avatar gabizou commented on June 1, 2024

Question is, should this be the expected behavior or leave as-is?

That's why I created the issue so we can get some feedback from other people ;)

from sponge.

Mumfrey avatar Mumfrey commented on June 1, 2024

Maybe actually allow the plugin to control this? Plugin creating world can say "load this even if I'm not present" or "only load if I am present". Could even be as simple as marking the world with an "owner" (plugin), which if present is required to load the world, and if left blank (by the seeding plugin) will allow the world to load regardless.

The import of this issue resolves to plugins which provide world generation features. A plugin should be able to say "loading this world without me present will cause bad chunks/weird shit" vs. a plugin saying, "I'm creating this, it's a regular world in all other respects so go ahead and load it regardless.

tl;dr If in doubt, make it configurable.

from sponge.

boformer avatar boformer commented on June 1, 2024

If you want provide multi-world support, do it right: Add a worlds config and maybe some commands to load/create/unload worlds.

Or follow the vanilla behavior: Without plugins, only load one world.

from sponge.

ST-DDT avatar ST-DDT commented on June 1, 2024

Yes. World should only be loaded if the server is requested to do so. Either by config oder method call.

from sponge.

JBYoshi avatar JBYoshi commented on June 1, 2024

I agree with Mumfrey - allow the WorldBuilder to set this.

from sponge.

TheRaspPie avatar TheRaspPie commented on June 1, 2024

@JBYoshi

  • you can't easily see which world requires which plugin, which is bad for transparency
  • you shouldn't mix the concerns of when to load a world with the actual content of it
  • personally, I think it's ugly if you have a server writing any data other than Vanilla to a world folder

EDIT: #116 may be related to my last point...

from sponge.

Zidane avatar Zidane commented on June 1, 2024

Closing, admins have full control over loading a world and it is up to them if they let a world load when a vital plugin/mod is missing.

from sponge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.