Git Product home page Git Product logo

Comments (3)

lephino avatar lephino commented on June 2, 2024

The clone is left that way to allow easier changing of branch used by the upstream ci/cd system. It allows the make var to be set instead of needing the hash / sha to be set on the module init. Not sure we'll change to sub modules. Any real reason for the request?

from docker-splunk.

ryanfaircloth avatar ryanfaircloth commented on June 2, 2024

My reasons are transparency, both through web UI and the directory structure the external repository inclusion is obvious unless you get into how the make and images work the external code and any risks are not really transparent.

from docker-splunk.

arctan5x avatar arctan5x commented on June 2, 2024

@rfaircloth-splunk @lephino

We probably won't be including this change. Closing this for now. If this issue becomes critical, feel free to reopen and escalate to the dev team.

from docker-splunk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.