Git Product home page Git Product logo

Comments (5)

trollkotze avatar trollkotze commented on August 14, 2024

Changing the line
if($val == '' || !count($val)) continue;
to
if($val == '' || is_null($val) || (is_array($val) && count($val) == 0)) continue;
seems to be a valid workaround.

from dokuwiki-plugin-data.

splitbrain avatar splitbrain commented on August 14, 2024

Can you send a pull request?

from dokuwiki-plugin-data.

trollkotze avatar trollkotze commented on August 14, 2024

Okay, I did. Just am not completely sure if that is all there is to it, just my particular use-case does not print a warning anymore.

Oh, and it seems Travis CI fails for all 7.x PHP versions. But not showing what exactly fails, which lines of code are wrong. I suspect it might be just because of other similar cases where some instructions were too laissez-faire for PHP 7.x.

from dokuwiki-plugin-data.

layolayo avatar layolayo commented on August 14, 2024

Had the same issue with the discussions plugin - line 425 in action.php (docuwiki/lib/plugins/discussion)
$cnt = count($data['comments'])

is changed to:

    if($data['comments'] == '' || is_null($data['comments']) || (is_array($data['comments']) && count($data['comments']) == 0)) {
		$cnt = 0;
	} else {
		$cnt = count($data['comments']);
	}

from dokuwiki-plugin-data.

Floffyko avatar Floffyko commented on August 14, 2024

Same story here. Waiting for a verified solution. The workaround above is welcome.

from dokuwiki-plugin-data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.