Comments (4)
Actually I'm not sure what is supposed to happen on a duplicate...right now I get the "An unknown error occurred." flash, no asset is added, but an additional json file is still created.
from craft-embedded-assets.
After some testing, it only happens on certain cases, eg: https://youtu.be/IkgyWsdRnx8
It seems to be because the filename doesn't match when it looks for a duplicate.
The filename that is uploaded first is embed_What-To-Wear-Episode-2.json
but when it compares it with subsequent uploads, it is embed_What-To-Wear-Episode-2-.json
from craft-embedded-assets.
Looks like you just need to do $fileName = AssetsHelper::cleanAssetName($filePrefix . $fileLabel . $fileExtension);
PR coming :)
from craft-embedded-assets.
Interesting. I had that clean asset name call in there before but took it out because it was buggy with certain foreign characters, and then rolled my own. Thanks for pull request, merging now 👍
from craft-embedded-assets.
Related Issues (20)
- Where do I set the embedded data? HOT 1
- getVideoId not working with Dailymotion HOT 4
- TikTok URLs can't be added HOT 1
- UX: Moving of assets not possible HOT 2
- Limit What Volumes Can Use Embedded Assets HOT 1
- Limit Asset Selection by Type HOT 1
- Limit urls by domain (example youtube only) HOT 2
- Direct vimeo urls in Craft 4.4.5 don't work HOT 1
- Google maps embed only returns a link HOT 2
- Error embedding Instagram: max 10 redirects followed HOT 1
- Twitter embeds HOT 1
- Failed queue jobs for Checking whether Instagram embedded asset needs to be refreshed
- How to use in module/plugin HOT 1
- Wistia embed support? HOT 7
- Can't embed youtube/vimeo videos now HOT 2
- TypeError: Cannot read properties of undefined (reading 'folderId') HOT 10
- Include Inputs to capture required Craft asset field values HOT 2
- YouTube embeds are now being added as Link type instead of Video HOT 4
- update dependency on "embed/embed" to version v4.4 or higher HOT 1
- Update embed/embed to v4 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from craft-embedded-assets.